From: Dan Carley <dan.carley@gmail.com>
Date: Mon, 16 Sep 2013 11:34:07 +0000 (+0100)
Subject: [#153] Variablise file paths in unattended spec
X-Git-Tag: 1.3.0~1^2~3
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=f185a57cd64c83816b0183161956e0adc608eaa7;p=puppet-modules%2Fpuppetlabs-apt.git

[#153] Variablise file paths in unattended spec

Reduce some duplication of long file paths.
---

diff --git a/spec/classes/unattended_upgrades_spec.rb b/spec/classes/unattended_upgrades_spec.rb
index 097f7a5..17a21ca 100644
--- a/spec/classes/unattended_upgrades_spec.rb
+++ b/spec/classes/unattended_upgrades_spec.rb
@@ -1,5 +1,7 @@
 require 'spec_helper'
 describe 'apt::unattended_upgrades', :type => :class do
+  let(:file_unattended) { '/etc/apt/apt.conf.d/50unattended-upgrades' }
+  let(:file_periodic) { '/etc/apt/apt.conf.d/10periodic' }
 
   it { should contain_package("unattended-upgrades") }
 
@@ -23,71 +25,71 @@ describe 'apt::unattended_upgrades', :type => :class do
     let :params do
       { :origins => ['ubuntu:precise-security'] }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::Allowed-Origins \{\n\t"ubuntu:precise-security";\n\};$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::Allowed-Origins \{\n\t"ubuntu:precise-security";\n\};$/) }
   end
   
   describe "with blacklist => []" do
     let :params do
       { :blacklist => [] }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::Package-Blacklist \{\n\};$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::Package-Blacklist \{\n\};$/) }
   end
   
   describe "with update => 2" do
     let :params do
       { :update => "2" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::Update-Package-Lists "2";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::Update-Package-Lists "2";$/) }
   end
   
   describe "with download => 2" do
     let :params do
       { :download => "2" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::Download-Upgradeable-Packages "2";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::Download-Upgradeable-Packages "2";$/) }
   end
   
   describe "with upgrade => 2" do
     let :params do
       { :upgrade => "2" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::Unattended-Upgrade "2";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::Unattended-Upgrade "2";$/) }
   end
   
   describe "with autoclean => 2" do
     let :params do
       { :autoclean => "2" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::AutocleanInterval "2";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::AutocleanInterval "2";$/) }
   end
   
   describe "with auto_fix => false" do
     let :params do
       { :auto_fix => false }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::AutoFixInterruptedDpkg "false";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::AutoFixInterruptedDpkg "false";$/) }
   end
   
   describe "with minimal_steps => true" do
     let :params do
       { :minimal_steps => true }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::MinimalSteps "true";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::MinimalSteps "true";$/) }
   end
   
   describe "with install_on_shutdown => true" do
     let :params do
       { :install_on_shutdown => true }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::InstallOnShutdown "true";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::InstallOnShutdown "true";$/) }
   end
   
   describe "with mail_to => NONE" do
     let :params do
       { :mail_to => "NONE" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^\/\/ 'mailx' must be installed.\n$/) }
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^\/\/ is to always send a mail if Unattended-Upgrade::Mail is set\n$/) }
+    it { should contain_file(file_unattended).with_content(/^\/\/ 'mailx' must be installed.\n$/) }
+    it { should contain_file(file_unattended).with_content(/^\/\/ is to always send a mail if Unattended-Upgrade::Mail is set\n$/) }
   end
   
   describe "with mail_to => user@website, mail_only_on_error => true" do
@@ -95,85 +97,85 @@ describe 'apt::unattended_upgrades', :type => :class do
       { :mail_to => "user@website",
         :mail_only_on_error => true }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::Mail "user@website";$/) }
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::MailOnlyOnError "true";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::Mail "user@website";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::MailOnlyOnError "true";$/) }
   end
   
   describe "with remove_unused => false" do
     let :params do
       { :remove_unused => false }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::Remove-Unused-Dependencies "false";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::Remove-Unused-Dependencies "false";$/) }
   end
   
   describe "with auto_reboot => true" do
     let :params do
       { :auto_reboot => true }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Unattended-Upgrade::Automatic-Reboot "true";$/) }
+    it { should contain_file(file_unattended).with_content(/^Unattended-Upgrade::Automatic-Reboot "true";$/) }
   end
   
   describe "with dl_limit => 70" do
     let :params do
       { :dl_limit => "70" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/50unattended-upgrades').with_content(/^Acquire::http::Dl-Limit "70";$/) }
+    it { should contain_file(file_unattended).with_content(/^Acquire::http::Dl-Limit "70";$/) }
   end
   
   describe "with enable => 0" do
     let :params do
       { :enable => "0" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::Enable "0";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::Enable "0";$/) }
   end
   
   describe "with backup_interval => 1" do
     let :params do
       { :backup_interval => "1" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::BackUpArchiveInterval "1";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::BackUpArchiveInterval "1";$/) }
   end
   
   describe "with backup_level => 0" do
     let :params do
       { :backup_level => "0" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::BackUpLevel "0";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::BackUpLevel "0";$/) }
   end
   
   describe "with max_age => 1" do
     let :params do
       { :max_age => "1" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::MaxAge "1";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::MaxAge "1";$/) }
   end
   
   describe "with min_age => 1" do
     let :params do
       { :min_age => "1" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::MinAge "1";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::MinAge "1";$/) }
   end
   
   describe "with max_size => 1" do
     let :params do
       { :max_size => "1" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::MaxSize "1";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::MaxSize "1";$/) }
   end
   
   describe "with download_delta => 2" do
     let :params do
       { :download_delta => "2" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::Download-Upgradeable-Packages-Debdelta "2";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::Download-Upgradeable-Packages-Debdelta "2";$/) }
   end
   
   describe "with verbose => 2" do
     let :params do
       { :verbose => "2" }
     end
-    it { should contain_file('/etc/apt/apt.conf.d/10periodic').with_content(/^APT::Periodic::Verbose "2";$/) }
+    it { should contain_file(file_periodic).with_content(/^APT::Periodic::Verbose "2";$/) }
   end
   
 end