From: Javier Pena <jpena@redhat.com>
Date: Wed, 28 Feb 2018 14:20:47 +0000 (+0100)
Subject: Do not skip gnocchi resource type creation by default in db::sync
X-Git-Tag: 13.0.0~15
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=e985087545cf116ea30a8d270e4adb11aa86f994;p=puppet-modules%2Fpuppet-ceilometer.git

Do not skip gnocchi resource type creation by default in db::sync

The default command-line option for ceilometer-upgrade is to not
skip gnocchi resource type creation. If we do not pass any extra_params
to the ceilometer::db::sync class, we should keep defaults.

This has not failed before in CI because p-o-i was passing
'--skip-metering-database' as extra_params, but now we are removing
that deprecated option in [1].

[1] - https://review.openstack.org/548337

Change-Id: I33c1667e19326ec67c5cf953daa1237175895c4f
---

diff --git a/manifests/db/sync.pp b/manifests/db/sync.pp
index db08f6d..07d400f 100644
--- a/manifests/db/sync.pp
+++ b/manifests/db/sync.pp
@@ -7,10 +7,10 @@
 # [*extra_params*]
 #   (Optional) String of extra command line parameters
 #   to append to the ceilometer-upgrade command.
-#   Defaults to '--skip-gnocchi-resource-types'.
+#   Defaults to undef.
 #
 class ceilometer::db::sync(
-  $extra_params = '--skip-gnocchi-resource-types',
+  $extra_params = undef,
 ) {
 
   include ::ceilometer::deps
diff --git a/spec/acceptance/ceilometer_wsgi_apache_spec.rb b/spec/acceptance/ceilometer_wsgi_apache_spec.rb
index 677768f..5994c01 100644
--- a/spec/acceptance/ceilometer_wsgi_apache_spec.rb
+++ b/spec/acceptance/ceilometer_wsgi_apache_spec.rb
@@ -47,6 +47,8 @@ describe 'ceilometer with mysql' do
         database_connection => 'mysql+pymysql://ceilometer:a_big_secret@127.0.0.1/ceilometer?charset=utf8',
 	sync_db             => false,
       }
+      # NOTE(tobasco): When running the beaker tests we need to exclude the
+      # gnocchi resource types since the acceptance test does not setup gnocchi itself.
       class { '::ceilometer::db::sync':
         extra_params => '--skip-gnocchi-resource-types',
       }
diff --git a/spec/classes/ceilometer_db_sync_spec.rb b/spec/classes/ceilometer_db_sync_spec.rb
index f57e132..d794019 100644
--- a/spec/classes/ceilometer_db_sync_spec.rb
+++ b/spec/classes/ceilometer_db_sync_spec.rb
@@ -6,7 +6,7 @@ describe 'ceilometer::db::sync' do
 
     it 'runs ceilometer-upgrade' do
       is_expected.to contain_exec('ceilometer-upgrade').with(
-        :command     => 'ceilometer-upgrade --skip-gnocchi-resource-types',
+        :command     => 'ceilometer-upgrade ',
         :path        => '/usr/bin',
         :refreshonly => 'true',
         :user        => 'ceilometer',