From: Christian Berendt <berendt@b1-systems.de>
Date: Fri, 4 Jul 2014 11:12:26 +0000 (+0200)
Subject: Raise NotImplementedError instead of NotImplemented
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=e8e2392321e0fd3e2b8a0345b725f2e8df854a34;p=openstack-build%2Fneutron-build.git

Raise NotImplementedError instead of NotImplemented

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).

NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).

It makes no sense to raise a constant. The exception should
be raised instead.

Change-Id: I4969e26eb7b46f008ea3c8bd0093490c425f7069
Closes-Bug: #1339855
---

diff --git a/neutron/agent/linux/polling.py b/neutron/agent/linux/polling.py
index 23168085f..9e2163ac2 100644
--- a/neutron/agent/linux/polling.py
+++ b/neutron/agent/linux/polling.py
@@ -52,7 +52,7 @@ class BasePollingManager(object):
         self._polling_completed = True
 
     def _is_polling_required(self):
-        raise NotImplemented
+        raise NotImplementedError()
 
     @property
     def is_polling_required(self):
diff --git a/neutron/tests/unit/agent/linux/test_polling.py b/neutron/tests/unit/agent/linux/test_polling.py
index 90b48e0bc..ba18a8648 100644
--- a/neutron/tests/unit/agent/linux/test_polling.py
+++ b/neutron/tests/unit/agent/linux/test_polling.py
@@ -43,6 +43,9 @@ class TestBasePollingManager(base.BaseTestCase):
         super(TestBasePollingManager, self).setUp()
         self.pm = polling.BasePollingManager()
 
+    def test__is_polling_required_should_not_be_implemented(self):
+        self.assertRaises(NotImplementedError, self.pm._is_polling_required)
+
     def test_force_polling_sets_interval_attribute(self):
         self.assertFalse(self.pm._force_polling)
         self.pm.force_polling()