From: Cedric Brandily <zzelle@gmail.com>
Date: Fri, 24 Apr 2015 19:20:40 +0000 (+0200)
Subject: Remove RecursivePermDirFixture useless cleanup
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=e78a49c86cc00cb92bc143dc6d72747c9d875297;p=openstack-build%2Fneutron-build.git

Remove RecursivePermDirFixture useless cleanup

This change removes a useless cleanup in RecursivePermDirFixture:
previously RecursivePermDirFixture reverts permission changes on
directories, but the cleanup is useless as directories are provided
by TempDir.

Change-Id: I76c8dbefe3b42ec34a50fb164b9cbc25f4ac4245
---

diff --git a/neutron/tests/functional/agent/linux/helpers.py b/neutron/tests/functional/agent/linux/helpers.py
index 611a42304..6e003b515 100644
--- a/neutron/tests/functional/agent/linux/helpers.py
+++ b/neutron/tests/functional/agent/linux/helpers.py
@@ -50,16 +50,9 @@ class RecursivePermDirFixture(fixtures.Fixture):
             perms = os.stat(current_directory).st_mode
             if perms & self.least_perms != self.least_perms:
                 os.chmod(current_directory, perms | self.least_perms)
-                self.addCleanup(self.safe_chmod, current_directory, perms)
             previous_directory = current_directory
             current_directory = os.path.dirname(current_directory)
 
-    def safe_chmod(self, path, mode):
-        try:
-            os.chmod(path, mode)
-        except OSError:
-            pass
-
 
 def get_free_namespace_port(tcp=True, namespace=None):
     """Return an unused port from given namespace