From: Matthew Thode <mthode@mthode.org>
Date: Wed, 6 May 2015 19:39:20 +0000 (-0500)
Subject: changes log level to debug for help calls
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=dd9129d42cf280458301d5101a131c4c5c12abdf;p=openstack-build%2Fneutron-build.git

changes log level to debug for help calls

Calling help typically causes the program being called to exit non-zero.
This causes the command to be logged as an error even though it should not be.
By setting 'log_fail_as_error=False' we log to debug.  This helps clean
up logs.

Change-Id: I13f9488b9bc524bb85047e9b2dcf4e8a76bd6c11
Closes-Bug: 1452425
---

diff --git a/neutron/agent/linux/ip_lib.py b/neutron/agent/linux/ip_lib.py
index 943fd543c..9cbd5e7a2 100644
--- a/neutron/agent/linux/ip_lib.py
+++ b/neutron/agent/linux/ip_lib.py
@@ -673,7 +673,7 @@ def ensure_device_is_ready(device_name, namespace=None):
 def iproute_arg_supported(command, arg):
     command += ['help']
     stdout, stderr = utils.execute(command, check_exit_code=False,
-                                   return_stderr=True)
+                                   return_stderr=True, log_fail_as_error=False)
     return any(arg in line for line in stderr.split('\n'))