From: Takashi Kajinami <tkajinam@redhat.com>
Date: Thu, 23 Sep 2021 13:37:02 +0000 (+0900)
Subject: [hardware] readonly_user_password should be secret
X-Git-Tag: 19.4.0~9^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=d987257e4ef452653650aa03bab748be7c207b3e;p=puppet-modules%2Fpuppet-ceilometer.git

[hardware] readonly_user_password should be secret

... because the parameter accepts a password string.

Change-Id: I362b09f60c22d615ed13c79bbc25f27f3b73feb5
---

diff --git a/manifests/init.pp b/manifests/init.pp
index 079b4ab..c4d514f 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -395,7 +395,7 @@ will be removed in a future release.')
     'DEFAULT/host'                        : value => $host;
     'publisher/telemetry_secret'          : value => $telemetry_secret, secret => true;
     'hardware/readonly_user_name'         : value => $snmpd_readonly_username;
-    'hardware/readonly_user_password'     : value => $snmpd_readonly_user_password;
+    'hardware/readonly_user_password'     : value => $snmpd_readonly_user_password, secret => true;
   }
 
   oslo::messaging::notifications { 'ceilometer_config':
diff --git a/spec/classes/ceilometer_init_spec.rb b/spec/classes/ceilometer_init_spec.rb
index e51a7a9..1b08343 100644
--- a/spec/classes/ceilometer_init_spec.rb
+++ b/spec/classes/ceilometer_init_spec.rb
@@ -119,7 +119,7 @@ describe 'ceilometer' do
 
     it 'configures snmpd auth' do
       is_expected.to contain_ceilometer_config('hardware/readonly_user_name').with_value('<SERVICE DEFAULT>')
-      is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>')
+      is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>').with_secret(true)
     end
 
     it 'configures cache backend' do