From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Date: Mon, 3 Sep 2012 11:07:25 +0000 (+0900)
Subject: Fix programming error of ryu-plugin
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=d296a1f0aad5bb5596b0676d5ac7742c557995e1;p=openstack-build%2Fneutron-build.git

Fix programming error of ryu-plugin

Fixes bug 1045275

This patch fixes a programming error of the ryu-plugin.

Change-Id: I4226e3bdf9611ce25298b37b7ba9e6be8a9e3cba
---

diff --git a/quantum/plugins/ryu/agent/ryu_quantum_agent.py b/quantum/plugins/ryu/agent/ryu_quantum_agent.py
index 1b3c253bd..943123d40 100755
--- a/quantum/plugins/ryu/agent/ryu_quantum_agent.py
+++ b/quantum/plugins/ryu/agent/ryu_quantum_agent.py
@@ -148,7 +148,7 @@ class OVSQuantumOFPRyuAgent:
 
     def _all_bindings(self, db):
         """return interface id -> port which include network id bindings"""
-        return dict((port.device_id, port) for port in db.ports.all())
+        return dict((port.id, port) for port in db.ports.all())
 
     def _set_port_status(self, port, status):
         port.status = status
@@ -190,13 +190,13 @@ class OVSQuantumOFPRyuAgent:
                 if old_b == new_b:
                     continue
 
-                if not old_b:
+                if old_b:
                     LOG.info("Removing binding to net-id = %s for %s",
                              old_b, str(port))
                     if port.vif_id in all_bindings:
                         self._set_port_status(all_bindings[port.vif_id],
                                               constants.PORT_STATUS_DOWN)
-                if not new_b:
+                if new_b:
                     if port.vif_id in all_bindings:
                         self._set_port_status(all_bindings[port.vif_id],
                                               constants.PORT_STATUS_ACTIVE)