From: Jake Yip <jake.yip@unimelb.edu.au>
Date: Wed, 21 Jun 2017 03:35:05 +0000 (+1000)
Subject: Add ensure value for user and group resources
X-Git-Tag: 11.2.0~10^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=cf96476c22e8af7b4fcb2640d358466fc1279e91;p=puppet-modules%2Fpuppet-ceilometer.git

Add ensure value for user and group resources

'ensure' property for user and group type resource has no default value;
if we are managing ceilometer user and group we should set ensure to
'present' so that the resources get created.

Also make user depend on group resource being created first.

Change-Id: Ie5b2704b3ea9a7727c6ff4f06efcbea201e6314a
---

diff --git a/manifests/init.pp b/manifests/init.pp
index c209f99..a73a6b0 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -361,11 +361,13 @@ please use memcache_servers instead.")
   }
 
   group { 'ceilometer':
+    ensure  => present,
     name    => 'ceilometer',
     require => Anchor['ceilometer::install::end'],
   }
 
   user { 'ceilometer':
+    ensure  => present,
     name    => 'ceilometer',
     gid     => 'ceilometer',
     system  => true,
diff --git a/spec/classes/ceilometer_init_spec.rb b/spec/classes/ceilometer_init_spec.rb
index a7e9f65..02e8650 100644
--- a/spec/classes/ceilometer_init_spec.rb
+++ b/spec/classes/ceilometer_init_spec.rb
@@ -84,6 +84,7 @@ describe 'ceilometer' do
 
     it 'configures ceilometer group' do
       is_expected.to contain_group('ceilometer').with(
+        :ensure  => 'present',
         :name    => 'ceilometer',
         :require => 'Anchor[ceilometer::install::end]'
       )
@@ -91,6 +92,7 @@ describe 'ceilometer' do
 
     it 'configures ceilometer user' do
       is_expected.to contain_user('ceilometer').with(
+        :ensure  => 'present',
         :name    => 'ceilometer',
         :gid     => 'ceilometer',
         :system  => true,