From: Ryan Moats Date: Mon, 24 Aug 2015 13:49:09 +0000 (-0500) Subject: Remove redundant logging statements from RootWrapDaemonHelper X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=ccf73311c862f4f62a5012b6fcb4459b2d2bef17;p=openstack-build%2Fneutron-build.git Remove redundant logging statements from RootWrapDaemonHelper create_process and execute_rootwrap_daemon both current log the command they are about to run. Remove these statements as redundant (the log message showing the command's result includes the command itself) Signed-off-by: Ryan Moats Change-Id: I8bdea7212f8a32a3b6b0b47c5b824ac1c561d83f --- diff --git a/neutron/agent/linux/utils.py b/neutron/agent/linux/utils.py index 95c47a060..67be8ad49 100644 --- a/neutron/agent/linux/utils.py +++ b/neutron/agent/linux/utils.py @@ -83,7 +83,6 @@ def create_process(cmd, run_as_root=False, addl_env=None): cmd = list(map(str, addl_env_args(addl_env) + cmd)) if run_as_root: cmd = shlex.split(config.get_root_helper(cfg.CONF)) + cmd - LOG.debug("Running command: %s", cmd) obj = utils.subprocess_popen(cmd, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, @@ -99,7 +98,6 @@ def execute_rootwrap_daemon(cmd, process_input, addl_env): # In practice, no neutron code should be trying to execute something that # would throw those errors, and if it does it should be fixed as opposed to # just logging the execution error. - LOG.debug("Running command (rootwrap daemon): %s", cmd) client = RootwrapDaemonHelper.get_client() return client.execute(cmd, process_input)