From: Eric Harney <eharney@redhat.com>
Date: Tue, 9 Feb 2016 16:57:32 +0000 (-0500)
Subject: Log stack trace for middleware faults
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=ccdfd0448b3f97d8fe533472f09274703c7e650f;p=openstack-build%2Fcinder-build.git

Log stack trace for middleware faults

If an error occurs in the middleware layer,
such as an exception generated by keystoneclient,
there is no stack trace provided, leaving the
issue difficult to debug.

Log a stack trace here with LOG.exception instead.

Change-Id: I7bc7c74e8b701fac351572a3bb9d934c7f67d425
---

diff --git a/cinder/api/middleware/fault.py b/cinder/api/middleware/fault.py
index f667ae4d8..9aa9e6456 100644
--- a/cinder/api/middleware/fault.py
+++ b/cinder/api/middleware/fault.py
@@ -44,9 +44,9 @@ class FaultWrapper(base_wsgi.Middleware):
 
     def _error(self, inner, req):
         if not isinstance(inner, exception.QuotaError):
-            LOG.error(_LE("Caught error: %(type)s %(error)s"),
-                      {'type': type(inner),
-                       'error': inner})
+            LOG.exception(_LE("Caught error: %(type)s %(error)s"),
+                          {'type': type(inner),
+                           'error': inner})
         safe = getattr(inner, 'safe', False)
         headers = getattr(inner, 'headers', None)
         status = getattr(inner, 'code', 500)