From: Qin Zhao <chaochin@gmail.com>
Date: Wed, 30 Oct 2013 16:37:43 +0000 (+0800)
Subject: Examine if GPFS is mounted before writing data.
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=cb1d1e4241c6ecb99797a46053c43b2e4b3b52e7;p=openstack-build%2Fcinder-build.git

Examine if GPFS is mounted before writing data.

If GPFS is not mounted, throw an exception and log the error message. That will
prevent create_volume(), copy_image_to_volume() or _clone_image() to create
file on local disk, which can not be removed by the driver code itself.

Change-Id: If5d4c7a88e82362d2a87068202926b1ca82d9dff
Closes-Bug: #1242511
---

diff --git a/cinder/volume/drivers/gpfs.py b/cinder/volume/drivers/gpfs.py
index a2b01c387..2e5b8119c 100644
--- a/cinder/volume/drivers/gpfs.py
+++ b/cinder/volume/drivers/gpfs.py
@@ -192,14 +192,8 @@ class GPFSDriver(driver.VolumeDriver):
                 LOG.error(msg)
                 raise exception.VolumeBackendAPIException(data=msg)
 
-            try:
-                # check that configured directories are on GPFS
-                self._is_gpfs_path(directory)
-            except processutils.ProcessExecutionError:
-                msg = (_('%s is not on GPFS. Perhaps GPFS not mounted.') %
-                       directory)
-                LOG.error(msg)
-                raise exception.VolumeBackendAPIException(data=msg)
+            # Check if GPFS is mounted
+            self._verify_gpfs_path_state(directory)
 
             fs, fslevel = self._get_gpfs_filesystem_release_level(directory)
             if not fslevel >= GPFS_CLONE_MIN_RELEASE:
@@ -260,6 +254,9 @@ class GPFSDriver(driver.VolumeDriver):
 
     def create_volume(self, volume):
         """Creates a GPFS volume."""
+        # Check if GPFS is mounted
+        self._verify_gpfs_path_state(self.configuration.gpfs_mount_point_base)
+
         volume_path = self.local_path(volume)
         volume_size = volume['size']
 
@@ -489,6 +486,9 @@ class GPFSDriver(driver.VolumeDriver):
         gpfs clone operation or with a file copy. If the image format is not
         raw, convert it to raw at the volume path.
         """
+        # Check if GPFS is mounted
+        self._verify_gpfs_path_state(self.configuration.gpfs_mount_point_base)
+
         cloneable_image, reason, image_path = self._is_cloneable(image_id)
         if not cloneable_image:
             LOG.debug('Image %(img)s not cloneable: %(reas)s' %
@@ -536,6 +536,9 @@ class GPFSDriver(driver.VolumeDriver):
         case, this function is invoked and uses fetch_to_raw to create the
         volume.
         """
+        # Check if GPFS is mounted
+        self._verify_gpfs_path_state(self.configuration.gpfs_mount_point_base)
+
         LOG.debug('Copy image to vol %s using image_utils fetch_to_raw' %
                   volume['id'])
         image_utils.fetch_to_raw(context, image_service, image_id,
@@ -592,3 +595,13 @@ class GPFSDriver(driver.VolumeDriver):
         size = int(out.split()[1])
         available = int(out.split()[3])
         return available, size
+
+    def _verify_gpfs_path_state(self, path):
+        """Examine if GPFS is active and file system is mounted or not."""
+        try:
+            self._is_gpfs_path(path)
+        except processutils.ProcessExecutionError:
+            msg = (_('%s cannot be accessed. Verify that GPFS is active and '
+                     'file system is mounted.') % path)
+            LOG.error(msg)
+            raise exception.VolumeBackendAPIException(data=msg)