From: Wlodzimierz Borkowski <wlodek.borkowski@gmail.com>
Date: Sat, 25 Oct 2014 12:59:24 +0000 (+0200)
Subject: Add assertion to test_page_reverse method
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=c615b7602ce50c21a8347e0c501170ee1f97d11c;p=openstack-build%2Fneutron-build.git

Add assertion to test_page_reverse method

In neutron/tests/unit/test_api_v2.APIv2TestCase.test_page_reverse
there is no second call to test_case with 'page_reverse': 'False,
because of use assert_called_once_with.
In proposed change before second testcase, reset_mock is called.
Remove also second 'instance' initialization.

Closes-Bug: #1373126
Change-Id: I552b7b47456a1cdfccdeb8d7853ec3395317097a
---

diff --git a/neutron/tests/unit/test_api_v2.py b/neutron/tests/unit/test_api_v2.py
index c52f937ff..61621e44f 100644
--- a/neutron/tests/unit/test_api_v2.py
+++ b/neutron/tests/unit/test_api_v2.py
@@ -368,18 +368,20 @@ class APIv2TestCase(APIv2TestBase):
         calls = []
         instance = self.plugin.return_value
         instance.get_networks.return_value = []
+
         self.api.get(_get_path('networks'),
                      {'page_reverse': 'True'})
         kwargs = self._get_collection_kwargs(page_reverse=True)
         calls.append(mock.call.get_networks(mock.ANY, **kwargs))
         instance.get_networks.assert_called_once_with(mock.ANY, **kwargs)
 
-        instance = self.plugin.return_value
-        instance.get_networks.return_value = []
+        instance.get_networks.reset_mock()
+
         self.api.get(_get_path('networks'),
                      {'page_reverse': 'False'})
         kwargs = self._get_collection_kwargs(page_reverse=False)
         calls.append(mock.call.get_networks(mock.ANY, **kwargs))
+        instance.get_networks.assert_called_once_with(mock.ANY, **kwargs)
 
     def test_page_reverse_with_non_bool(self):
         instance = self.plugin.return_value