From: Dirk Mueller Date: Fri, 14 Jun 2013 21:37:11 +0000 (+0200) Subject: Run flake8 also on cinder/*/openstack X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=c1da47d7ce3efea1b3055f1d4a6c2b84799e8ef0;p=openstack-build%2Fcinder-build.git Run flake8 also on cinder/*/openstack exclude=openstack also matches cinder/api/openstack, which is however not merged from oslo-incubator. Exclude=common instead, and explicitely include cinder/common Change-Id: I331d8c0d17e519386ae72caeca8a336eecde3ad3 --- diff --git a/cinder/api/openstack/wsgi.py b/cinder/api/openstack/wsgi.py index 34118ac66..a2101c196 100644 --- a/cinder/api/openstack/wsgi.py +++ b/cinder/api/openstack/wsgi.py @@ -183,12 +183,11 @@ class XMLDeserializer(TextDeserializer): """Search a nodes children for the first child with a given name.""" for node in parent.childNodes: if (node.localName == name and - node.namespaceURI and - node.namespaceURI == namespace): + node.namespaceURI and + node.namespaceURI == namespace): return node return None - def find_first_child_named(self, parent, name): """Search a nodes children for the first child with a given name""" for node in parent.childNodes: diff --git a/tox.ini b/tox.ini index c55515da9..cac92ed0c 100644 --- a/tox.ini +++ b/tox.ini @@ -21,7 +21,7 @@ downloadcache = ~/cache/pip [testenv:pep8] sitepackages = False commands = - flake8 {posargs} + flake8 {posargs} . cinder/common flake8 --filename=cinder* bin [testenv:pylint] @@ -45,4 +45,4 @@ commands = {posargs} [flake8] ignore = E711,E712,F401,F403,F811,F841,H302,H303,H304,H402,H404 builtins = _ -exclude = .venv,.tox,dist,doc,openstack,*egg,build +exclude = .git,.venv,.tox,dist,doc,common,*egg,build