From: Zane Bitter <zbitter@redhat.com>
Date: Fri, 6 Jul 2012 18:40:00 +0000 (+0200)
Subject: Report errors from nested stacks
X-Git-Tag: 2014.1~1619
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=bd24e183c1a404286f9b701feb18819d353544b9;p=openstack-build%2Fheat-build.git

Report errors from nested stacks

If creation of a nested stack fails, we need to raise an exception so that
creation of the nested stack resource (and hence the enclosing stack) also
fails.

Change-Id: Ic5eda7f8d044ed2c87fc0e785b1cd8fcf78071a4
Signed-off-by: Zane Bitter <zbitter@redhat.com>
---

diff --git a/heat/engine/stack.py b/heat/engine/stack.py
index f35ae753..cbc46aed 100644
--- a/heat/engine/stack.py
+++ b/heat/engine/stack.py
@@ -69,6 +69,8 @@ class Stack(Resource):
         nested_id = self._nested.store(self.stack)
         self.instance_id_set(nested_id)
         self._nested.create()
+        if self._nested.state != self._nested.CREATE_COMPLETE:
+            raise exception.Error(self._nested.state_description)
 
     def handle_create(self):
         response = urllib2.urlopen(self.properties[PROP_TEMPLATE_URL])