From: lisali <xiaoyan.li@intel.com>
Date: Thu, 25 Feb 2016 02:19:13 +0000 (+0000)
Subject: Fix NoneType error in service_get_all
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=bd1f6c91250148451aff6660211cf0296b91f5de;p=openstack-build%2Fcinder-build.git

Fix NoneType error in service_get_all

When calling service_get_all without filters,
it raises NoneType error which is imported by
this patch I21775106693176ca128dbfd9db0d43cfc58de00a.

Change-Id: I473a9bbd2caea21c6fcd82b483bece1337ab6535
Closes-Bug: 1549563
---

diff --git a/cinder/db/sqlalchemy/api.py b/cinder/db/sqlalchemy/api.py
index a5620fa09..407c4999c 100644
--- a/cinder/db/sqlalchemy/api.py
+++ b/cinder/db/sqlalchemy/api.py
@@ -379,15 +379,16 @@ def service_get_all(context, filters=None):
 
     query = model_query(context, models.Service)
 
-    try:
-        host = filters.pop('host')
-        host_attr = models.Service.host
-        conditions = or_(host_attr == host, host_attr.op('LIKE')(host + '@%'))
-        query = query.filter(conditions)
-    except KeyError:
-        pass
-
     if filters:
+        try:
+            host = filters.pop('host')
+            host_attr = models.Service.host
+            conditions = or_(host_attr ==
+                             host, host_attr.op('LIKE')(host + '@%'))
+            query = query.filter(conditions)
+        except KeyError:
+            pass
+
         query = query.filter_by(**filters)
 
     return query.all()
diff --git a/cinder/tests/unit/test_db_api.py b/cinder/tests/unit/test_db_api.py
index c1165f9a2..daa3eaf0d 100644
--- a/cinder/tests/unit/test_db_api.py
+++ b/cinder/tests/unit/test_db_api.py
@@ -191,6 +191,7 @@ class DBAPIServiceTestCase(BaseTest):
         expected_bin = services[1:3]
         compares = [
             (services, db.service_get_all(self.ctxt, {})),
+            (services, db.service_get_all(self.ctxt)),
             (expected, db.service_get_all(self.ctxt, {'host': 'host1'})),
             (expected_bin, db.service_get_all(self.ctxt, {'binary': 'b2'})),
             (disabled_services, db.service_get_all(self.ctxt,