From: John Griffith <john.griffith@solidfire.com>
Date: Wed, 29 Apr 2015 23:25:12 +0000 (-0600)
Subject: Add retry to lvm delete
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=b813f3f807019fa4e87de644674fc41051b63118;p=openstack-build%2Fcinder-build.git

Add retry to lvm delete

Seems we have another issue related to lvm and
snapshots, but this time it's on the delete side.

We used a simple retry mechanism for snapshot create
here:
  https://review.openstack.org/#/c/149360/8

I'm hesitant to just add another retry without looking
at dm issues, but this should address the problem
temporarily and give us a chance to collect some
data on the issue.

Change-Id: I37607a09e2f9af6f2f32ddfaa8567400541e533a
Closes-Bug: #1450110
---

diff --git a/cinder/brick/local_dev/lvm.py b/cinder/brick/local_dev/lvm.py
index 9a0c26464..f4c7753c8 100644
--- a/cinder/brick/local_dev/lvm.py
+++ b/cinder/brick/local_dev/lvm.py
@@ -625,6 +625,7 @@ class LVM(executor.Executor):
             LOG.error(_LE('StdErr  :%s'), err.stderr)
             raise
 
+    @utils.retry(putils.ProcessExecutionError)
     def delete(self, name):
         """Delete logical volume or snapshot.