From: Walter A. Boring IV Date: Wed, 25 Mar 2015 16:35:51 +0000 (-0700) Subject: Added the missing attachment to detach_volume X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=b792d5ccbf3968b547b7e1fbd474a9ec8060be2c;p=openstack-build%2Fcinder-build.git Added the missing attachment to detach_volume I must have missed this driver in the multiattach patch. The attachment object is passed in to detach_volume to give drivers a chance to deal with a detach call. This patch just updates the signature of the method to be the same as the parent. Change-Id: I895c163e67d35df202a5490a7a31ee7fc13a0cb4 Closes-Bug: #1436367 --- diff --git a/cinder/volume/drivers/openvstorage.py b/cinder/volume/drivers/openvstorage.py index 7dc643d84..050ee7eeb 100644 --- a/cinder/volume/drivers/openvstorage.py +++ b/cinder/volume/drivers/openvstorage.py @@ -383,7 +383,7 @@ class OVSVolumeDriver(driver.VolumeDriver): """Callback for volume attached to instance or host.""" pass - def detach_volume(self, context, volume): + def detach_volume(self, context, volume, attachment=None): """Callback for volume detached.""" pass