From: Daniele Sluijters <github@daenney.net>
Date: Wed, 5 Mar 2014 15:12:04 +0000 (+0100)
Subject: pin: Replace invalid chars with _ in file names.
X-Git-Tag: 1.5.0~29^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=b560fa265f12435d6a262f715dd2d885bf067e14;p=puppet-modules%2Fpuppetlabs-apt.git

pin: Replace invalid chars with _ in file names.

This needs to be merged for #259 to work.
---

diff --git a/manifests/pin.pp b/manifests/pin.pp
index 9cb4a8e..0d4d742 100644
--- a/manifests/pin.pp
+++ b/manifests/pin.pp
@@ -68,7 +68,17 @@ define apt::pin(
     ''      => "${preferences_d}/${name}.pref",
     default => "${preferences_d}/${order}-${name}.pref",
   }
-  file { "${name}.pref":
+
+  # According to man 5 apt_preferences:
+  # The files have either no or "pref" as filename extension
+  # and only contain alphanumeric, hyphen (-), underscore (_) and period
+  # (.) characters. Otherwise APT will print a notice that it has ignored a
+  # file, unless that file matches a pattern in the
+  # Dir::Ignore-Files-Silently configuration list - in which case it will
+  # be silently ignored.
+  $file_name = regsubst($title, '[^0-9a-z\-_\.]', '_', 'IG')
+
+  file { "${file_name}.pref":
     ensure  => $ensure,
     path    => $path,
     owner   => root,
diff --git a/spec/defines/pin_spec.rb b/spec/defines/pin_spec.rb
index f1ca437..6438e8c 100644
--- a/spec/defines/pin_spec.rb
+++ b/spec/defines/pin_spec.rb
@@ -105,4 +105,16 @@ describe 'apt::pin', :type => :define do
       }
     end
   end
+
+  describe 'resource title with invalid chars' do
+    context 'spaces' do
+      let(:title) { 'oh my god this is not valid' }
+      it { should contain_file('oh_my_god_this_is_not_valid.pref') }
+    end
+
+    context '#$&*$' do
+      let(:title) { 'so && many $* invalid @! things' }
+      it { should contain_file('so____many____invalid____things.pref') }
+    end
+  end
 end