From: Kjetil Torgrim Homme <kjetil.homme@redpill-linpro.com>
Date: Wed, 1 Dec 2021 21:31:32 +0000 (+0100)
Subject: fix spurious fail, http/udp does not exist in test harness
X-Git-Tag: v4.0.0~12^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=ae6459864a165666451d24b740cfaf0ee3491eeb;p=puppet-modules%2Fpuppetlabs-firewall.git

fix spurious fail, http/udp does not exist in test harness

Switch to "talk" (port 517), since that is an UDP only service in the default Debian and RedHat /etc/services.
---

diff --git a/spec/unit/puppet/provider/iptables_spec.rb b/spec/unit/puppet/provider/iptables_spec.rb
index 5aaf9b8..918cf64 100644
--- a/spec/unit/puppet/provider/iptables_spec.rb
+++ b/spec/unit/puppet/provider/iptables_spec.rb
@@ -331,14 +331,14 @@ describe 'iptables provider' do
                                        chain: 'nova-compute-FORWARD',
                                        source: '0.0.0.0/32',
                                        destination: '255.255.255.255/32',
-                                       sport: ['! 78', '79', 'http'],
+                                       sport: ['! 78', '79', 'talk'],
                                        dport: ['77', '! 76'],
                                        proto: 'udp')
     end
     let(:instance) { provider.new(resource) }
 
     it 'fails when not all array items are inverted' do
-      expect { instance.insert }.to raise_error RuntimeError, %r{but '79', '80' are not prefixed}
+      expect { instance.insert }.to raise_error RuntimeError, %r{but '79', '517' are not prefixed}
     end
   end