From: John Griffith <john.griffith@solidfire.com>
Date: Wed, 28 Jan 2015 04:20:38 +0000 (-0600)
Subject: Add debug message for lvremove after udev settle
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=aac29b3a5c7dcbc6c582fff52b477fcda6bfbdc6;p=openstack-build%2Fcinder-build.git

Add debug message for lvremove after udev settle

Just add a simple debug level log message for lvremove calls that
are made and successfully completed as part of error recovery.

Currently some platforms commonly receive a "Unable to deactivate"
error message when running an lvremove.  We have a retry mechanism
that performs a udevsettle and retries that in most cases results
in a succesful removal.

This patch just adds an explicit debug log message so we can track
this more easily and gather some statistical data on it.

Change-Id: I8f2480491f3cb7f078597113f967c1e285fdf105
---

diff --git a/cinder/brick/local_dev/lvm.py b/cinder/brick/local_dev/lvm.py
index 9776ddf2e..bba753bf9 100644
--- a/cinder/brick/local_dev/lvm.py
+++ b/cinder/brick/local_dev/lvm.py
@@ -626,6 +626,8 @@ class LVM(executor.Executor):
                 '-f',
                 '%s/%s' % (self.vg_name, name),
                 root_helper=self._root_helper, run_as_root=True)
+            LOG.debug('Successfully deleted volume: %s after '
+                      'udev settle.', name)
 
     def revert(self, snapshot_name):
         """Revert an LV from snapshot.