From: Jenkins <jenkins@review.openstack.org>
Date: Fri, 17 May 2013 18:40:53 +0000 (+0000)
Subject: Merge "Align usage of test skipping."
X-Git-Tag: 2014.1~595
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=a9d05bbbd1430e4a69d43e7133d98e63e827214e;p=openstack-build%2Fheat-build.git

Merge "Align usage of test skipping."
---

a9d05bbbd1430e4a69d43e7133d98e63e827214e
diff --cc heat/tests/test_quantum.py
index 045b75a7,fb41f069..f8a22c12
--- a/heat/tests/test_quantum.py
+++ b/heat/tests/test_quantum.py
@@@ -316,37 -328,21 +316,38 @@@ class QuantumSubnetTest(HeatTestCase)
          self.m.VerifyAll()
  
  
 +@skipIf(quantumclient is None, 'quantumclient unavailable')
  class QuantumFloatingIPTest(HeatTestCase):
+     @skipIf(net.clients.quantumclient is None, "Missing Quantum Client")
      def setUp(self):
          super(QuantumFloatingIPTest, self).setUp()
 -        self.m.StubOutWithMock(floatingip.FloatingIP, 'quantum')
 -        self.m.StubOutWithMock(floatingip.FloatingIPAssociation, 'quantum')
 -        self.m.StubOutWithMock(port.Port, 'quantum')
 +        self.m.StubOutWithMock(quantumclient.Client, 'create_floatingip')
 +        self.m.StubOutWithMock(quantumclient.Client, 'delete_floatingip')
 +        self.m.StubOutWithMock(quantumclient.Client, 'show_floatingip')
 +        self.m.StubOutWithMock(quantumclient.Client, 'update_floatingip')
 +        self.m.StubOutWithMock(quantumclient.Client, 'create_port')
 +        self.m.StubOutWithMock(quantumclient.Client, 'delete_port')
 +        self.m.StubOutWithMock(quantumclient.Client, 'show_port')
          setup_dummy_db()
  
 -    @skipIf(net.clients.quantumclient is None, 'quantumclient unavailable')
      def test_floating_ip(self):
  
 -        fq = FakeQuantum()
 -        floatingip.FloatingIP.quantum().MultipleTimes().AndReturn(fq)
 +        quantumclient.Client.create_floatingip({
 +            'floatingip': {'floating_network_id': u'abcd1234'}
 +        }).AndReturn({'floatingip': {
 +            "status": "ACTIVE",
 +            "id": "fc68ea2c-b60b-4b4f-bd82-94ec81110766"
 +        }})
 +
 +        quantumclient.Client.show_floatingip(
 +            'fc68ea2c-b60b-4b4f-bd82-94ec81110766'
 +        ).MultipleTimes().AndReturn({'floatingip': {
 +            "status": "ACTIVE",
 +            "id": "fc68ea2c-b60b-4b4f-bd82-94ec81110766"
 +        }})
  
 +        quantumclient.Client.delete_floatingip(
 +            'fc68ea2c-b60b-4b4f-bd82-94ec81110766').AndReturn(None)
          self.m.ReplayAll()
  
          t = template_format.parse(quantum_floating_template)