From: Zhongyue Luo <zhongyue.nah@intel.com>
Date: Mon, 21 Jan 2013 08:57:46 +0000 (+0800)
Subject: Removes redundant code in quantum.api.api_common
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=a8da14c0fd3edb941b0dd4a2fa44c00a68a89798;p=openstack-build%2Fneutron-build.git

Removes redundant code in quantum.api.api_common

Fixes bug #1102313

Change-Id: Ie321c48ae6d38f013e1ef8471df4d86b63b28931
---

diff --git a/quantum/api/api_common.py b/quantum/api/api_common.py
index 2e781e66c..0dd1bf726 100644
--- a/quantum/api/api_common.py
+++ b/quantum/api/api_common.py
@@ -15,11 +15,11 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-
 from webob import exc
 
 from quantum.openstack.common import log as logging
 
+
 LOG = logging.getLogger(__name__)
 
 
@@ -49,13 +49,12 @@ class QuantumController(object):
                                      self._resource_name)
         for param in params:
             param_name = param['param-name']
-            param_value = data.get(param_name, None)
+            param_value = data.get(param_name)
             # If the parameter wasn't found and it was required, return 400
             if param_value is None and param['required']:
                 msg = (_("Failed to parse request. "
                          "Parameter '%s' not specified") % param_name)
-                for line in msg.split('\n'):
-                    LOG.error(line)
+                LOG.error(msg)
                 raise exc.HTTPBadRequest(msg)
             data[param_name] = param_value or param.get('default-value')
         return body