From: Salvatore Orlando <salv.orlando@gmail.com>
Date: Thu, 7 Mar 2013 13:19:16 +0000 (+0100)
Subject: NVP plugin: configure metadata network only if overlapping IPs are enabled
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=9951582d33f57ed53e0a3ece9f1f81623faba032;p=openstack-build%2Fneutron-build.git

NVP plugin: configure metadata network only if overlapping IPs are enabled

Bug 1152144

This patch also add a warning emitted in the logs at startup if the
configuration is not correct.

Change-Id: Idbf10c64f068a71ef1ed9c29a6a0c4e736bb975d
---

diff --git a/quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py b/quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py
index 4d64f3edd..5c66047a8 100644
--- a/quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py
+++ b/quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py
@@ -132,6 +132,11 @@ def parse_config():
         cfg.CONF.set_override(
             'api_extensions_path',
             'quantum/plugins/nicira/nicira_nvp_plugin/extensions')
+    if (cfg.CONF.NVP.enable_metadata_access_network and
+        not cfg.CONF.allow_overlapping_ips):
+        LOG.warn(_("Overlapping IPs must be enabled in order to setup "
+                   "the metadata access network. Metadata access in "
+                   "routed mode will not work with this configuration"))
     return cfg.CONF.NVP, clusters_options
 
 
diff --git a/quantum/plugins/nicira/nicira_nvp_plugin/common/metadata_access.py b/quantum/plugins/nicira/nicira_nvp_plugin/common/metadata_access.py
index f3a07aea7..81fdf66e5 100644
--- a/quantum/plugins/nicira/nicira_nvp_plugin/common/metadata_access.py
+++ b/quantum/plugins/nicira/nicira_nvp_plugin/common/metadata_access.py
@@ -117,6 +117,10 @@ class NvpMetadataAccess(object):
         if not cfg.CONF.NVP.enable_metadata_access_network:
             LOG.debug(_("Metadata access network is disabled"))
             return
+        if not cfg.CONF.allow_overlapping_ips:
+            LOG.warn(_("Overlapping IPs must be enabled in order to setup "
+                       "the metadata access network"))
+            return
         # As we'll use a different device_owner for metadata interface
         # this query will return only 'real' router interfaces
         ctx_elevated = context.elevated()