From: Damon Breeden <damon.breeden@ahrefs.com>
Date: Fri, 2 Dec 2022 16:04:56 +0000 (+0000)
Subject: debian: service: fix `ensure` parameter usage
X-Git-Tag: v4.1.0~7^2~4
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=993419129d6451cabf05660dabe44f75d5b79288;p=puppet-modules%2Fpuppetlabs-firewall.git

debian: service: fix `ensure` parameter usage

`ensure` is defined but not used anywhere, no clear way to ensure the service is running
(and makes it impossible to do so outside the module)
---

diff --git a/manifests/linux/debian.pp b/manifests/linux/debian.pp
index c8363d2..b8d6cde 100644
--- a/manifests/linux/debian.pp
+++ b/manifests/linux/debian.pp
@@ -34,7 +34,7 @@ class firewall::linux::debian (
   # This isn't a real service/daemon. The start action loads rules, so just
   # needs to be called on system boot.
   service { $service_name:
-    ensure    => undef,
+    ensure    => $ensure,
     enable    => $enable,
     hasstatus => true,
     require   => Package[$package_name],