From: Angus Lees <gus@inodes.org>
Date: Wed, 22 Oct 2014 11:11:10 +0000 (+1100)
Subject: Enable super-on-old-class pylint check
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=935deb399426c9dd12d899c0b61a59461c3f4275;p=openstack-build%2Fneutron-build.git

Enable super-on-old-class pylint check

.. and disable the check locally for two midonet and Ryu classes that
fail since the midonet/ryu libraries are unavailable in our toxenv.

Change-Id: Idca46f853e6a116e8b2c246b4c6cae159894f887
---

diff --git a/.pylintrc b/.pylintrc
index ad9c8211b..d44dee4f8 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -25,7 +25,6 @@ disable=
  no-method-argument,
  no-self-argument,
  no-value-for-parameter,
- super-on-old-class,
 # "W" Warnings for stylistic problems or minor programming issues
  abstract-method,
  arguments-differ,
diff --git a/neutron/plugins/midonet/plugin.py b/neutron/plugins/midonet/plugin.py
index 67d46d019..d310a51c3 100644
--- a/neutron/plugins/midonet/plugin.py
+++ b/neutron/plugins/midonet/plugin.py
@@ -36,6 +36,9 @@ midonet_opts = [
 cfg.CONF.register_opts(midonet_opts, "MIDONET")
 
 
+# Derives from `object` (via at least NeutronDbPluginV2), but pylint
+# can't see that without having the midonet libraries available.
+# pylint: disable=super-on-old-class
 class MidonetPluginV2(plugin.MidonetMixin):
 
     vendor_extensions = plugin.MidonetMixin.supported_extension_aliases
diff --git a/neutron/plugins/ofagent/agent/ofa_neutron_agent.py b/neutron/plugins/ofagent/agent/ofa_neutron_agent.py
index dc1a5256f..af6977cf6 100644
--- a/neutron/plugins/ofagent/agent/ofa_neutron_agent.py
+++ b/neutron/plugins/ofagent/agent/ofa_neutron_agent.py
@@ -123,6 +123,9 @@ class Bridge(flows.OFAgentIntegrationBridge, ovs_lib.OVSBridge):
         self.get_datapath(retry_max)
 
 
+# RyuApp derives from `object`, but pylint can't see that without
+# having the ryu libraries available.
+# pylint: disable=super-on-old-class
 class OFANeutronAgentRyuApp(app_manager.RyuApp):
     OFP_VERSIONS = [ryu_ofp13.OFP_VERSION]