From: Mathieu Gagné <mgagne@iweb.com>
Date: Tue, 28 Jan 2014 23:13:01 +0000 (-0500)
Subject: Remove glance_notifications from notification_topic
X-Git-Tag: 4.0.0~19^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=924f18ffae174847d4c3d5ec5d5ae4241c9dd897;p=puppet-modules%2Fpuppet-ceilometer.git

Remove glance_notifications from notification_topic

The default notification_topic in Glance has been changed from
'glance_notifications' to 'notifications' in grizzly-2.

Ceilometer was configured to also listen on the
'glance_notifications' notification_topic in addition to
'notifications' to patch this bug. It shouldn't anymore.

Change-Id: I3d797c7e849319a1e20ef3ecbf158e8b8579d450
Closes-bug: #1273876
---

diff --git a/manifests/init.pp b/manifests/init.pp
index 5488144..2493386 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -183,13 +183,9 @@ class ceilometer(
     'DEFAULT/log_dir'                : value => $log_dir;
     'DEFAULT/verbose'                : value => $verbose;
     # Fix a bad default value in ceilometer.
-    # Fixed in https: //review.openstack.org/#/c/18487/
+    # Fixed in https://review.openstack.org/#/c/18487/
     'DEFAULT/glance_control_exchange': value => 'glance';
-    # Add glance-notifications topic.
-    # Fixed in glance https://github.com/openstack/glance/commit/2e0734e077ae
-    # Fix will be included in Grizzly
-    'DEFAULT/notification_topics'    :
-      value => 'notifications,glance_notifications';
+    'DEFAULT/notification_topics'    : value => 'notifications';
   }
 
   # Syslog configuration
diff --git a/spec/classes/ceilometer_init_spec.rb b/spec/classes/ceilometer_init_spec.rb
index 2db4794..b3d1113 100644
--- a/spec/classes/ceilometer_init_spec.rb
+++ b/spec/classes/ceilometer_init_spec.rb
@@ -148,8 +148,8 @@ describe 'ceilometer' do
       should contain_ceilometer_config('DEFAULT/glance_control_exchange').with_value('glance')
     end
 
-    it 'adds glance-notifications topic' do
-      should contain_ceilometer_config('DEFAULT/notification_topics').with_value('notifications,glance_notifications')
+    it 'configures notification_topics' do
+      should contain_ceilometer_config('DEFAULT/notification_topics').with_value('notifications')
     end
   end