From: Victor Stinner Date: Tue, 9 Feb 2016 13:56:51 +0000 (+0100) Subject: hacking: Fix false positive in C302 check X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=917d476180552ba83e9675268d8b479504ed29a1;p=openstack-build%2Fcinder-build.git hacking: Fix false positive in C302 check Use a regular expression to search for "unicode(" instead of a static string to not complain to "exception_to_unicode(error)". Change-Id: I0a969b184054f287cef463bbcb980bfb4a0a6803 --- diff --git a/cinder/hacking/checks.py b/cinder/hacking/checks.py index 52ff7b7bf..7652ae655 100644 --- a/cinder/hacking/checks.py +++ b/cinder/hacking/checks.py @@ -400,13 +400,16 @@ def check_datetime_now(logical_line, noqa): yield(0, msg) +_UNICODE_USAGE_REGEX = re.compile(r'\bunicode *\(') + + def check_unicode_usage(logical_line, noqa): if noqa: return msg = "C302: Found unicode() call. Please use six.text_type()." - if 'unicode(' in logical_line: + if _UNICODE_USAGE_REGEX.search(logical_line): yield(0, msg)