From: Akihiro Motoki Date: Sat, 30 Aug 2014 16:47:24 +0000 (+0900) Subject: Fix comments in api.rpc.handlers X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=8fb175bffd1b02262447478215d81b2a3edbe6a1;p=openstack-build%2Fneutron-build.git Fix comments in api.rpc.handlers Follow-up patch of RPC refactoring of bug 1359416. It addresses minor comments in the above patch series. Change-Id: I2d6268db777f0f73fda61a5a7d0967a91bcb292b Closes-Bug: #1359416 --- diff --git a/neutron/api/rpc/handlers/securitygroups_rpc.py b/neutron/api/rpc/handlers/securitygroups_rpc.py index 857e99d8c..2a748cfbc 100644 --- a/neutron/api/rpc/handlers/securitygroups_rpc.py +++ b/neutron/api/rpc/handlers/securitygroups_rpc.py @@ -17,14 +17,11 @@ from neutron import manager # TODO(amotoki): Move security group RPC API and agent callback -# from securitygroups_rpc.py. +# from neutron/agent/securitygroups_rpc.py. class SecurityGroupServerRpcCallback(n_rpc.RpcCallback): - """Callback for SecurityGroup agent RPC in plugin implementations. - - Subclass which inherits this class must implement get_port_from_device(). - """ + """Callback for SecurityGroup agent RPC in plugin implementations.""" # API version history: # 1.1 - Initial version diff --git a/neutron/plugins/ml2/rpc.py b/neutron/plugins/ml2/rpc.py index 52d3980d9..d9cb07efd 100644 --- a/neutron/plugins/ml2/rpc.py +++ b/neutron/plugins/ml2/rpc.py @@ -40,7 +40,9 @@ class RpcCallbacks(n_rpc.RpcCallback, # 1.0 Initial version (from openvswitch/linuxbridge) # 1.1 Support Security Group RPC # 1.2 Support get_devices_details_list - # 1.3 Support Distributed Virtual Router (DVR) + # 1.3 get_device_details rpc signature upgrade to obtain 'host' and + # return value to include fixed_ips and device_owner for + # the device port def __init__(self, notifier, type_manager): self.setup_tunnel_callback_mixin(notifier, type_manager)