From: Eric Harney <eharney@redhat.com>
Date: Fri, 13 Feb 2015 18:07:46 +0000 (-0500)
Subject: Tests: Don't require binding to port 4444
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=8b0d47e7156563e0b64afcf3aa1b95f1f177d334;p=openstack-build%2Fcinder-build.git

Tests: Don't require binding to port 4444

If some other process is listening on port 4444,
test_server_pool_waitall will fail with:

RuntimeError: Could not bind to 127.0.0.1:4444 after
trying for 30 seconds

This test doesn't require use of this specific port,
so let it pick an unused port to avoid this failure.

Closes-Bug: #1421759

Change-Id: I7e6d6f574cd2bbb2fa067001bba4b09b5204a5e1
---

diff --git a/cinder/tests/test_wsgi.py b/cinder/tests/test_wsgi.py
index af70696a1..a304abdcf 100644
--- a/cinder/tests/test_wsgi.py
+++ b/cinder/tests/test_wsgi.py
@@ -140,7 +140,7 @@ class TestWSGIServer(test.TestCase):
     def test_server_pool_waitall(self):
         # test pools waitall method gets called while stopping server
         server = cinder.wsgi.Server("test_server", None,
-                                    host="127.0.0.1", port=4444)
+                                    host="127.0.0.1")
         server.start()
         with mock.patch.object(server._pool,
                                'waitall') as mock_waitall: