From: Eric Harney <eharney@redhat.com>
Date: Mon, 16 Dec 2013 22:44:02 +0000 (-0500)
Subject: Pylint fixes for GlusterFS driver
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=8904259b94481ca9e177c988f50ecabdecd117a4;p=openstack-build%2Fcinder-build.git

Pylint fixes for GlusterFS driver

Remove unused 're' import
Remove unused parameter for _create_snapshot()

Change-Id: I40411b6206d282ae07c905faa44dcccecb45c120
---

diff --git a/cinder/volume/drivers/glusterfs.py b/cinder/volume/drivers/glusterfs.py
index bf2a49ad8..0cc82afe8 100644
--- a/cinder/volume/drivers/glusterfs.py
+++ b/cinder/volume/drivers/glusterfs.py
@@ -19,7 +19,6 @@ import errno
 import hashlib
 import json
 import os
-import re
 import stat
 import tempfile
 import time
@@ -453,8 +452,7 @@ class GlusterfsDriver(nfs.RemoteFsDriver):
         LOG.debug(_('volume id: %s') % snapshot['volume_id'])
 
         path_to_disk = self._local_path_volume(snapshot['volume'])
-        snap_id = snapshot['id']
-        self._create_snapshot(snapshot, path_to_disk, snap_id)
+        self._create_snapshot(snapshot, path_to_disk)
 
     def _create_qcow2_snap_file(self, snapshot, backing_filename,
                                 new_snap_path):
@@ -483,7 +481,7 @@ class GlusterfsDriver(nfs.RemoteFsDriver):
                    new_snap_path]
         self._execute(*command, run_as_root=True)
 
-    def _create_snapshot(self, snapshot, path_to_disk, snap_id):
+    def _create_snapshot(self, snapshot, path_to_disk):
         """Create snapshot (offline case)."""
 
         # Requires volume status = 'available'