From: Ken Barber Date: Thu, 27 Oct 2011 11:20:36 +0000 (+0100) Subject: (#10324) Remove extraneous whitespace from iptables rule line in spec tests X-Git-Tag: v0.0.3~6^2 X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=83663b82d9b4a8916f410de0a9994cef427b6f31;p=puppet-modules%2Fpuppetlabs-firewall.git (#10324) Remove extraneous whitespace from iptables rule line in spec tests The extra spaces between port numbers were messing up the parse and putting elements in the wrong parts of the hash during rule_to_hash. This wasn't causing a test problem now, but was creating an issue for other work people were doing on the module. --- diff --git a/spec/unit/puppet/provider/iptables_spec.rb b/spec/unit/puppet/provider/iptables_spec.rb index 4da37ed..19e70a4 100644 --- a/spec/unit/puppet/provider/iptables_spec.rb +++ b/spec/unit/puppet/provider/iptables_spec.rb @@ -109,7 +109,7 @@ describe 'iptables provider' do describe 'when converting rules without comments to resources' do let(:sample_rule) { - '-A INPUT -s 1.1.1.1 -d 1.1.1.1 -p tcp -m multiport --dports 7061,7062 -m multiport --sports 7061, 7062 -j ACCEPT' + '-A INPUT -s 1.1.1.1 -d 1.1.1.1 -p tcp -m multiport --dports 7061,7062 -m multiport --sports 7061,7062 -j ACCEPT' } let(:resource) { provider.rule_to_hash(sample_rule, 'filter', 0) } let(:instance) { provider.new(resource) } @@ -145,7 +145,7 @@ describe 'iptables provider' do describe 'when deleting resources' do let(:sample_rule) { - '-A INPUT -s 1.1.1.1 -d 1.1.1.1 -p tcp -m multiport --dports 7061,7062 -m multiport --sports 7061, 7062 -j ACCEPT' + '-A INPUT -s 1.1.1.1 -d 1.1.1.1 -p tcp -m multiport --dports 7061,7062 -m multiport --sports 7061,7062 -j ACCEPT' } let(:resource) { provider.rule_to_hash(sample_rule, 'filter', 0) } let(:instance) { provider.new(resource) }