From: Salvatore Orlando Date: Thu, 21 Jul 2011 15:34:58 +0000 (+0100) Subject: Restoring quantum_plugin_base to previous state. X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=7e8ae4a4166bf87c5d3f6bc5efa4dd59a9e3efbc;p=openstack-build%2Fneutron-build.git Restoring quantum_plugin_base to previous state. Will discuss in the future whether allow API layer to pass options to plugins upon initialization. --- diff --git a/quantum/manager.py b/quantum/manager.py index 14b7f979c..2a2383b3e 100644 --- a/quantum/manager.py +++ b/quantum/manager.py @@ -65,7 +65,7 @@ class QuantumManager(object): else: LOG.debug("Successfully imported Quantum plug-in." \ "All compatibility tests passed") - self.plugin = plugin_klass(options) + self.plugin = plugin_klass() def get_plugin(self): return self.plugin diff --git a/quantum/plugins.ini b/quantum/plugins.ini index 307d2b48d..448cab59e 100644 --- a/quantum/plugins.ini +++ b/quantum/plugins.ini @@ -1,3 +1,4 @@ [PLUGIN] # Quantum plugin provider module -provider = quantum.plugins.SamplePlugin.FakePlugin +#provider = quantum.plugins.SamplePlugin.FakePlugin +provider = quantum.plugins.openvswitch.ovs_quantum_plugin.OVSQuantumPlugin diff --git a/quantum/plugins/SamplePlugin.py b/quantum/plugins/SamplePlugin.py index 412d5f18b..8f46e4373 100644 --- a/quantum/plugins/SamplePlugin.py +++ b/quantum/plugins/SamplePlugin.py @@ -233,13 +233,8 @@ class FakePlugin(object): client/cli/api development """ - def __init__(self, options): - # use supplied options for configuring db - if not options: - options = {"sql_connection": "sqlite:///fake_plugin.sqllite"} - elif not 'sql_connection' in options: - options['sql_connection'] = "sqlite:///fake_plugin.sqllite" - db.configure_db(options) + def __init__(self): + db.configure_db({'sql_connection':'sqlite:///:memory:'}) FakePlugin._net_counter = 0 def _get_network(self, tenant_id, network_id): diff --git a/quantum/quantum_plugin_base.py b/quantum/quantum_plugin_base.py index e82c55253..3228f868c 100644 --- a/quantum/quantum_plugin_base.py +++ b/quantum/quantum_plugin_base.py @@ -30,14 +30,6 @@ class QuantumPluginBase(object): __metaclass__ = ABCMeta - @abstractmethod - def __init__(self, options): - """ - Initializes the Quantum plugin using provided options. - - """ - pass - @abstractmethod def get_all_networks(self, tenant_id): """ diff --git a/tests/unit/test_api.py b/tests/unit/test_api.py index 84339f715..c09af7699 100644 --- a/tests/unit/test_api.py +++ b/tests/unit/test_api.py @@ -615,10 +615,8 @@ class APITest(unittest.TestCase): "format:%s - END", format) def setUp(self): - self.db_file = ':memory:' options = {} options['plugin_provider'] = 'quantum.plugins.SamplePlugin.FakePlugin' - options['sql_connection'] = 'sqlite:///%s' % self.db_file self.api = server.APIRouterV01(options) self.tenant_id = "test_tenant" self.network_name = "test_network"