From: Jay S. Bryant Date: Sun, 3 Aug 2014 17:46:45 +0000 (-0500) Subject: Updated HACKING.rst so that it is accurate X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=79b6b98f210b47fb6313132ba8cfbb977bfb072e;p=openstack-build%2Fcinder-build.git Updated HACKING.rst so that it is accurate We haven't been very good at enforcing putting new hacking checks into HACKING.rst. This change brings the file up to date. Change-Id: I95ef533d031d333da5615ead997b54c6506c2c2a --- diff --git a/HACKING.rst b/HACKING.rst index 1f831845a..1d1440974 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -7,11 +7,13 @@ Cinder Style Commandments Cinder Specific Commandments ---------------------------- - +- [N314] Check for vi editor configuration in source files. - [N319] Validate that debug level logs are not translated +- [N322] Ensure default arguments are not mutable. - [N323] Add check for explicit import of _() to ensure proper translation. - [N324] Enforce no use of LOG.audit messages. LOG.info should be used instead. + General ------- - Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised::