From: Joshua Harlow <harlowja@yahoo-inc.com>
Date: Fri, 15 Aug 2014 00:02:32 +0000 (-0700)
Subject: Put result in quotes
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=765f61619de7f61a8fbe297ea8099e35f0216ea2;p=openstack-build%2Fcinder-build.git

Put result in quotes

When a result is the empty string is is hard/confusing
to look at the logs and determine what the task result
was, to avoid this put the result in quotes so that it
is clear in the log message what is the result and what
is not.

Change-Id: I6f9c30e30999dcd8d7f0df26f8066d9f392fe1b9
---

diff --git a/cinder/flow_utils.py b/cinder/flow_utils.py
index c5816c883..d10ef4894 100644
--- a/cinder/flow_utils.py
+++ b/cinder/flow_utils.py
@@ -107,7 +107,7 @@ class DynamicLogListener(base_listener.ListenerBase):
                     self._logger.log(level,
                                      _("Task '%(task_name)s' (%(task_uuid)s)"
                                        " transitioned into state '%(state)s'"
-                                       " with result %(result)s") %
+                                       " with result '%(result)s'") %
                                      {'task_name': details['task_name'],
                                       'task_uuid': details['task_uuid'],
                                       'state': state, 'result': result})