From: John Griffith <john.griffith@solidfire.com>
Date: Tue, 9 Jul 2013 01:22:34 +0000 (-0600)
Subject: SolidFire API RequestID is useless.
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=723486b120f3b2cc106c94191e8de9dc0b4c185f;p=openstack-build%2Fcinder-build.git

SolidFire API RequestID is useless.

The SolidFire API can take an int or a string for a request-id,
when using an int however it needs to actually be a valid int.

The driver currently was doing an int(uuid) which is too large and
as a result get's truncated making it difficult or impossible to track
request-ids.

This patch chanes the generate request-id to form a hash of the uuid so
that it can be tracked.

Fixed bug: 1199198

Change-Id: I38d5e3d189e679678898c329a9fa173a47853d47
---

diff --git a/cinder/volume/drivers/solidfire.py b/cinder/volume/drivers/solidfire.py
index ce4d56af6..1018bfb52 100644
--- a/cinder/volume/drivers/solidfire.py
+++ b/cinder/volume/drivers/solidfire.py
@@ -117,7 +117,7 @@ class SolidFire(SanISCSIDriver):
         # can't be re-used
         retry_count = 5
         while retry_count > 0:
-            request_id = int(uuid.uuid4())  # just generate a random number
+            request_id = hash(uuid.uuid4())  # just generate a random number
             command = {'method': method_name,
                        'id': request_id}