From: Félix-Antoine Fortin <felix-antoine.fortin@calculquebec.ca>
Date: Fri, 1 Oct 2021 18:17:45 +0000 (-0400)
Subject: Fix comment in uid and gid insync
X-Git-Tag: v3.3.0~5^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=6ee37ea79cb45239882457edc9ef413be064d799;p=puppet-modules%2Fpuppetlabs-firewall.git

Fix comment in uid and gid insync
---

diff --git a/lib/puppet/type/firewall.rb b/lib/puppet/type/firewall.rb
index 75724f7..e4cb1a2 100644
--- a/lib/puppet/type/firewall.rb
+++ b/lib/puppet/type/firewall.rb
@@ -1390,14 +1390,14 @@ Puppet::Type.newtype(:firewall) do
         should_negate = '!'
       end
 
-      # If 'should' contains anything other than digits,
+      # If 'should' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
       # to UID
       unless should[%r{[0-9]+(-[0-9]+)?}] == should
         should = Etc.getpwnam(should).uid
       end
 
-      # If 'is' contains anything other than digits,
+      # If 'is' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
       # to UID
       unless is[%r{[0-9]+(-[0-9]+)?}] == is
@@ -1439,16 +1439,16 @@ Puppet::Type.newtype(:firewall) do
         should_negate = '!'
       end
 
-      # If 'should' contains anything other than digits,
+      # If 'should' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
-      # to UID
+      # to GID
       unless should[%r{[0-9]+(-[0-9]+)?}] == should
         should = Etc.getgrnam(should).gid
       end
 
-      # If 'is' contains anything other than digits,
+      # If 'is' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
-      # to UID
+      # to GID
       unless is[%r{[0-9]+(-[0-9]+)?}] == is
         is = Etc.getgrnam(is).gid
       end