From: Zane Bitter Date: Mon, 11 Mar 2013 15:54:20 +0000 (+0100) Subject: Skip quantum unit tests if client not installed X-Git-Tag: 2014.1~780^2 X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=6624f85f9663e812f1fafabb73483888c7479743;p=openstack-build%2Fheat-build.git Skip quantum unit tests if client not installed Quantum is optional, so we should skip unit tests that require quantumclient if it is not available. Fixes bug 1152242 Change-Id: I6c399b1845adfe457051c372601db6352cdf6261 --- diff --git a/heat/tests/test_quantum.py b/heat/tests/test_quantum.py index 9b8d6514..ec602e09 100644 --- a/heat/tests/test_quantum.py +++ b/heat/tests/test_quantum.py @@ -19,6 +19,7 @@ import unittest import mox from nose.plugins.attrib import attr +from nose.exc import SkipTest from heat.common import context from heat.common import exception @@ -166,6 +167,9 @@ class QuantumTest(unittest.TestCase): 'admin_state_up': False}, props) def test_net(self): + if net.clients.quantumclient is None: + raise SkipTest + fq = FakeQuantum() net.Net.quantum().MultipleTimes().AndReturn(fq) @@ -232,6 +236,9 @@ class QuantumFloatingIPTest(unittest.TestCase): return stack def test_floating_ip(self): + if net.clients.quantumclient is None: + raise SkipTest + fq = FakeQuantum() floatingip.FloatingIP.quantum().MultipleTimes().AndReturn(fq) @@ -264,6 +271,9 @@ class QuantumFloatingIPTest(unittest.TestCase): self.m.VerifyAll() def test_port(self): + if net.clients.quantumclient is None: + raise SkipTest + fq = FakeQuantum() port.Port.quantum().MultipleTimes().AndReturn(fq) @@ -296,6 +306,9 @@ class QuantumFloatingIPTest(unittest.TestCase): self.m.VerifyAll() def test_floatip_port(self): + if net.clients.quantumclient is None: + raise SkipTest + fq = FakeQuantum() floatingip.FloatingIP.quantum().MultipleTimes().AndReturn(fq) floatingip.FloatingIPAssociation.quantum().\ diff --git a/heat/tests/test_template_format.py b/heat/tests/test_template_format.py index 9c6197e9..c92fdeb6 100644 --- a/heat/tests/test_template_format.py +++ b/heat/tests/test_template_format.py @@ -13,9 +13,11 @@ # under the License. from nose.plugins.attrib import attr +from nose.exc import SkipTest import os import unittest +from heat.engine import clients from heat.common import context from heat.common import template_format from heat.engine import parser @@ -146,6 +148,8 @@ class JsonYamlResolvedCompareTest(unittest.TestCase): self.assertEqual(stack1.resources[key].t, stack2.resources[key].t) def test_quantum_resolved(self): + if clients.quantumclient is None: + raise SkipTest self.compare_stacks('Quantum.template', 'Quantum.yaml', {}) def test_wordpress_resolved(self):