From: Jenkins Date: Sun, 14 Dec 2014 02:58:34 +0000 (+0000) Subject: Merge "Enforce log hints" X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=657f8a290bfbe3a5a9e6442f710d24b14c5cdd10;p=openstack-build%2Fneutron-build.git Merge "Enforce log hints" --- 657f8a290bfbe3a5a9e6442f710d24b14c5cdd10 diff --cc neutron/hacking/checks.py index 21c138730,76e49ad49..e2855e9f4 --- a/neutron/hacking/checks.py +++ b/neutron/hacking/checks.py @@@ -16,20 -16,21 +16,18 @@@ import r import pep8 -""" -Guidelines for writing new hacking checks - - - Use only for Neutron specific tests. OpenStack general tests - should be submitted to the common 'hacking' module. - - Pick numbers in the range N3xx. Find the current test with - the highest allocated number and then pick the next value. - - Keep the test method code in the source file ordered based - on the N3xx value. - - List the new rule in the top level HACKING.rst file - - Add test cases for each new rule to - neutron/tests/unit/test_hacking.py - -""" +# Guidelines for writing new hacking checks +# +# - Use only for Neutron specific tests. OpenStack general tests +# should be submitted to the common 'hacking' module. +# - Pick numbers in the range N3xx. Find the current test with +# the highest allocated number and then pick the next value. +# - Keep the test method code in the source file ordered based +# on the N3xx value. +# - List the new rule in the top level HACKING.rst file +# - Add test cases for each new rule to +# neutron/tests/unit/test_hacking.py - log_translation = re.compile( - r"(.)*LOG\.(audit|error|info|warn|warning|critical|exception)\(\s*('|\")") author_tag_re = (re.compile("^\s*#\s*@?(a|A)uthor"), re.compile("^\.\.\s+moduleauthor::")) _all_hints = set(['_', '_LI', '_LE', '_LW', '_LC'])