From: Ihar Hrachyshka <ihrachys@redhat.com>
Date: Wed, 22 Jul 2015 10:53:00 +0000 (+0200)
Subject: Revert "Mute neutron.callbacks notification logs."
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=517cf5b843922b6a789c4d4fd1381444acbb91d2;p=openstack-build%2Fneutron-build.git

Revert "Mute neutron.callbacks notification logs."

This reverts commit e19eb49c1c066c8fa4a3c19183bca1daef553a5c.

We don't use callbacks to extend resources, so no need to mute the logs.

Change-Id: I8eaffa243f74a8f93dfc1638727ac9cd0bdf505d
---

diff --git a/neutron/callbacks/manager.py b/neutron/callbacks/manager.py
index 8d32ff7ef..4927ff337 100644
--- a/neutron/callbacks/manager.py
+++ b/neutron/callbacks/manager.py
@@ -131,22 +131,14 @@ class CallbacksManager(object):
 
     def _notify_loop(self, resource, event, trigger, **kwargs):
         """The notification loop."""
-
-        #TODO(QoS): we found callback logs happening in the middle
-        #           of transactions being a source of DBDeadLocks
-        #           because they can yield. (Can LOG writes yield?,
-        #           please revisit this).
-        #
-        #LOG.debug("Notify callbacks for %(resource)s, %(event)s",
-        #          {'resource': resource, 'event': event})
+        LOG.debug("Notify callbacks for %(resource)s, %(event)s",
+                  {'resource': resource, 'event': event})
 
         errors = []
         # TODO(armax): consider using a GreenPile
         for callback_id, callback in self._callbacks[resource][event].items():
             try:
-                #TODO(QoS): muting logs for the reasons explained in the
-                #           previous TODO(QoS)
-                #LOG.debug("Calling callback %s", callback_id)
+                LOG.debug("Calling callback %s", callback_id)
                 callback(resource, event, trigger, **kwargs)
             except Exception as e:
                 LOG.exception(_LE("Error during notification for "