From: Ashley Penney Date: Mon, 24 Feb 2014 22:31:16 +0000 (+0000) Subject: Add lsbdistid facts where appropriate. X-Git-Tag: 1.5.0~40^2 X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=4d188443bc4f7b10581fedf2180573308bb2bf7b;p=puppet-modules%2Fpuppetlabs-apt.git Add lsbdistid facts where appropriate. --- diff --git a/spec/classes/apt_spec.rb b/spec/classes/apt_spec.rb index 6d87cc6..080bc81 100644 --- a/spec/classes/apt_spec.rb +++ b/spec/classes/apt_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt', :type => :class do + let(:facts) { { :lsbdistid => 'Debian' } } let :default_params do { :disable_keys => :undef, diff --git a/spec/classes/debian_testing_spec.rb b/spec/classes/debian_testing_spec.rb index 6006afb..ca55ef6 100644 --- a/spec/classes/debian_testing_spec.rb +++ b/spec/classes/debian_testing_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::debian::testing', :type => :class do + let(:facts) { { :lsbdistid => 'Debian' } } it { should contain_apt__source("debian_testing").with({ "location" => "http://debian.mirror.iweb.ca/debian/", diff --git a/spec/classes/debian_unstable_spec.rb b/spec/classes/debian_unstable_spec.rb index 411182d..f5ed455 100644 --- a/spec/classes/debian_unstable_spec.rb +++ b/spec/classes/debian_unstable_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::debian::unstable', :type => :class do + let(:facts) { { :lsbdistid => 'Debian' } } it { should contain_apt__source("debian_unstable").with({ "location" => "http://debian.mirror.iweb.ca/debian/", diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb index f2790b0..2d3ec3c 100644 --- a/spec/classes/params_spec.rb +++ b/spec/classes/params_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::params', :type => :class do + let(:facts) { { :lsbdistid => 'Debian' } } let (:title) { 'my_package' } it { should contain_apt__params } diff --git a/spec/classes/release_spec.rb b/spec/classes/release_spec.rb index 31252b9..e43f449 100644 --- a/spec/classes/release_spec.rb +++ b/spec/classes/release_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::release', :type => :class do + let(:facts) { { :lsbdistid => 'Debian' } } let (:title) { 'my_package' } let :param_set do diff --git a/spec/classes/unattended_upgrades_spec.rb b/spec/classes/unattended_upgrades_spec.rb index e83c6e4..f5cad53 100644 --- a/spec/classes/unattended_upgrades_spec.rb +++ b/spec/classes/unattended_upgrades_spec.rb @@ -2,6 +2,7 @@ require 'spec_helper' describe 'apt::unattended_upgrades', :type => :class do let(:file_unattended) { '/etc/apt/apt.conf.d/50unattended-upgrades' } let(:file_periodic) { '/etc/apt/apt.conf.d/10periodic' } + let(:facts) { { :lsbdistid => 'Debian' } } it { should contain_package("unattended-upgrades") } diff --git a/spec/defines/builddep_spec.rb b/spec/defines/builddep_spec.rb index 4e2b698..a0cbaa4 100644 --- a/spec/defines/builddep_spec.rb +++ b/spec/defines/builddep_spec.rb @@ -1,6 +1,7 @@ require 'spec_helper' describe 'apt::builddep', :type => :define do + let(:facts) { { :lsbdistid => 'Debian' } } let(:title) { 'my_package' } describe "should require apt-get update" do diff --git a/spec/defines/conf_spec.rb b/spec/defines/conf_spec.rb index 5a81b51..cda5900 100644 --- a/spec/defines/conf_spec.rb +++ b/spec/defines/conf_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::conf', :type => :define do + let(:facts) { { :lsbdistid => 'Debian' } } let :title do 'norecommends' end diff --git a/spec/defines/force_spec.rb b/spec/defines/force_spec.rb index 84231fa..0d3d6e5 100644 --- a/spec/defines/force_spec.rb +++ b/spec/defines/force_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::force', :type => :define do + let(:facts) { { :lsbdistid => 'Debian' } } let :pre_condition do 'include apt::params' end diff --git a/spec/defines/key_spec.rb b/spec/defines/key_spec.rb index aea197a..4ba7b87 100644 --- a/spec/defines/key_spec.rb +++ b/spec/defines/key_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::key', :type => :define do + let(:facts) { { :lsbdistid => 'Debian' } } let :title do '8347A27F' end diff --git a/spec/defines/pin_spec.rb b/spec/defines/pin_spec.rb index 179a2f3..5d3d312 100644 --- a/spec/defines/pin_spec.rb +++ b/spec/defines/pin_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::pin', :type => :define do + let(:facts) { { :lsbdistid => 'Debian' } } let(:title) { 'my_pin' } let :default_params do @@ -12,21 +13,21 @@ describe 'apt::pin', :type => :define do } end - [ + [ { :params => {}, :content => "# my_pin\nExplanation: : my_pin\nPackage: *\nPin: release a=my_pin\nPin-Priority: 0\n" }, { :params => { - :packages => 'apache', + :packages => 'apache', :priority => '1' }, :content => "# my_pin\nExplanation: : my_pin\nPackage: apache\nPin: release a=my_pin\nPin-Priority: 1\n" }, { :params => { - :order => 50, - :packages => 'apache', + :order => 50, + :packages => 'apache', :priority => '1' }, :content => "# my_pin\nExplanation: : my_pin\nPackage: apache\nPin: release a=my_pin\nPin-Priority: 1\n" diff --git a/spec/defines/ppa_spec.rb b/spec/defines/ppa_spec.rb index 6a571a8..0c3bd75 100644 --- a/spec/defines/ppa_spec.rb +++ b/spec/defines/ppa_spec.rb @@ -133,7 +133,8 @@ describe 'apt::ppa', :type => :define do end let :facts do {:lsbdistcodename => '#{platform[:lsbdistcodename]}', - :operatingsystem => 'Ubuntu'} + :operatingsystem => 'Ubuntu', + :lsbdistid => 'Ubuntu'} end let(:title) { "ppa" } let(:release) { "#{platform[:lsbdistcodename]}" } diff --git a/spec/defines/source_spec.rb b/spec/defines/source_spec.rb index 215d1e6..9da8b23 100644 --- a/spec/defines/source_spec.rb +++ b/spec/defines/source_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' describe 'apt::source', :type => :define do + let(:facts) { { :lsbdistid => 'Debian' } } let :title do 'my_source' end @@ -59,7 +60,7 @@ describe 'apt::source', :type => :define do end let :facts do - {:lsbdistcodename => 'karmic'} + {:lsbdistcodename => 'karmic', :lsbdistid => 'Ubuntu'} end let :params do @@ -160,7 +161,7 @@ describe 'apt::source', :type => :define do let(:default_params) { Hash.new } let(:facts) { Hash.new } it { expect { should raise_error(Puppet::Error) } } - let(:facts) { { :lsbdistcodename => 'lucid' } } + let(:facts) { { :lsbdistcodename => 'lucid', :lsbdistid => 'Ubuntu' } } it { should contain_apt__source(title) } end end