From: Patrick East <patrick.east@purestorage.com>
Date: Thu, 16 Jul 2015 21:18:04 +0000 (-0700)
Subject: Don’t log warnings in Pure initialize_connection
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=4aecec0c31a5c3c865d1980db6305b7774327cc9;p=openstack-build%2Fcinder-build.git

Don’t log warnings in Pure initialize_connection

This method can (and is) called multiple times for the same initiator
and volume combination. Our code handles that case correctly but will
log a warning which is misleading since it is perfectly ok.

Change-Id: Ibc7bafbcd6ecd114626330d608908c955ef8abe6
---

diff --git a/cinder/volume/drivers/pure.py b/cinder/volume/drivers/pure.py
index a3319a23e..fb840d613 100644
--- a/cinder/volume/drivers/pure.py
+++ b/cinder/volume/drivers/pure.py
@@ -577,9 +577,11 @@ class PureBaseVolumeDriver(san.SanDriver):
                 if (err.code == 400 and
                         "Connection already exists" in err.text):
                     # Happens if the volume is already connected to the host.
+                    # Treat this as a success.
                     ctxt.reraise = False
-                    LOG.warning(_LW("Volume connection already exists with "
-                                    "message: %s"), err.text)
+                    LOG.debug("Volume connection already exists for Purity "
+                              "host with message: %s", err.text)
+
                     # Get the info for the existing connection
                     connected_hosts = \
                         self._array.list_volume_private_connections(vol_name)