From: Angus Lees <gus@inodes.org>
Date: Tue, 21 Oct 2014 04:20:28 +0000 (+1100)
Subject: Enable assignment-from-no-return pylint check
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=4a46d19cacee2070785a4ffe948f44e97e8d5619;p=openstack-build%2Fneutron-build.git

Enable assignment-from-no-return pylint check

The @versioning.versioned decorator used (only) in
plugins.vmware.nsxlib.router completely confuses this check, so add a
file-local pylint disable.

Change-Id: I2a79a643a982f49faaf22b88764cb170ef89ce21
---

diff --git a/.pylintrc b/.pylintrc
index c738c547c..713494c10 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -19,7 +19,6 @@ disable=
  locally-disabled,
 # "E" Error for important programming issues (likely bugs)
  access-member-before-definition,
- assignment-from-no-return,
  bad-except-order,
  bad-super-call,
  maybe-no-member,
diff --git a/neutron/plugins/vmware/nsxlib/router.py b/neutron/plugins/vmware/nsxlib/router.py
index 254b4b6a5..2ef5245ab 100644
--- a/neutron/plugins/vmware/nsxlib/router.py
+++ b/neutron/plugins/vmware/nsxlib/router.py
@@ -26,6 +26,10 @@ from neutron.plugins.vmware import nsxlib
 from neutron.plugins.vmware.nsxlib import switch
 from neutron.plugins.vmware.nsxlib import versioning
 
+# @versioning.versioned decorator makes the apparent function body
+# totally unrelated to the real function.  This confuses pylint :(
+# pylint: disable=assignment-from-no-return
+
 HTTP_GET = "GET"
 HTTP_POST = "POST"
 HTTP_DELETE = "DELETE"