From: Helen Campbell <helen@puppet.com>
Date: Tue, 3 Oct 2017 14:11:17 +0000 (+0100)
Subject: Revert of PR 722 to undo the breaking changes introduced
X-Git-Tag: 1.10.0~10^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=4366d245c038bb79e29796fc34162f1eb0e765bb;p=puppet-modules%2Fpuppetlabs-firewall.git

Revert of PR 722 to undo the breaking changes introduced
---

diff --git a/README.markdown b/README.markdown
index 67b04e0..ccf7b9a 100644
--- a/README.markdown
+++ b/README.markdown
@@ -703,7 +703,7 @@ firewall { '999 this runs last':
   * 'icmp'
   * 'ipv4'
   * 'ipv6'
-  * 'icmpv6'
+  * 'ipv6-icmp'
   * 'esp'
   * 'ah'
   * 'vrrp'
diff --git a/lib/puppet/type/firewall.rb b/lib/puppet/type/firewall.rb
index 0bdd53e..55065f4 100644
--- a/lib/puppet/type/firewall.rb
+++ b/lib/puppet/type/firewall.rb
@@ -396,7 +396,7 @@ Puppet::Type.newtype(:firewall) do
       *tcp*.
     EOS
 
-    newvalues(*[:ip, :tcp, :udp, :icmp, :icmpv6, :esp, :ah, :vrrp, :igmp, :ipencap, :ipv4, :ipv6, :ospf, :gre, :cbt, :sctp, :pim, :all].collect do |proto|
+    newvalues(*[:ip, :tcp, :udp, :icmp, :"ipv6-icmp", :esp, :ah, :vrrp, :igmp, :ipencap, :ipv4, :ipv6, :ospf, :gre, :cbt, :sctp, :pim, :all].collect do |proto|
       [proto, "! #{proto}".to_sym]
     end.flatten)
     defaultto "tcp"