From: Mathieu Gagné <mgagne@iweb.com>
Date: Fri, 5 Apr 2013 01:50:37 +0000 (-0400)
Subject: Remove useless params
X-Git-Tag: grizzly-eol~15^2~9^2~6
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=3c60ed1f88e49f98a765a7708bd703fa36affc2f;p=puppet-modules%2Fpuppet-ceilometer.git

Remove useless params
---

diff --git a/manifests/init.pp b/manifests/init.pp
index df85919..f5688af 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -13,14 +13,18 @@ class ceilometer (
 
   include ceilometer::params
 
+  File {
+    require => Package['ceilometer-common'],
+  }
+
   group { 'ceilometer':
-    name    => $::ceilometer::params::groupname,
+    name    => 'ceilometer',
     require => Package['ceilometer-common'],
   }
 
   user { 'ceilometer':
-    name    => $::ceilometer::params::username,
-    gid     => $::ceilometer::params::groupname,
+    name    => 'ceilometer',
+    gid     => 'ceilometer',
     groups  => ['nova'],
     system  => true,
     require => Package['ceilometer-common'],
@@ -31,11 +35,9 @@ class ceilometer (
     owner   => 'ceilometer',
     group   => 'ceilometer',
     mode    => '0750',
-    require => Package['ceilometer-common'],
   }
 
   file { '/etc/ceilometer/ceilometer.conf':
-    ensure  => file,
     owner   => 'ceilometer',
     group   => 'ceilometer',
     mode    => '0640',
diff --git a/manifests/params.pp b/manifests/params.pp
index 698ffc0..916774e 100644
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -1,10 +1,7 @@
 #
 class ceilometer::params {
 
-  $username       = 'ceilometer'
-  $groupname      = 'ceilometer'
-  $cinder_conf    = '/etc/ceilometer/ceilometer.conf'
-  $dbsync_command = "ceilometer-dbsync --config-file=${cinder_conf}"
+  $dbsync_command = "ceilometer-dbsync --config-file=/etc/ceilometer/ceilometer.conf"
   $log_dir        = '/var/log/ceilometer'
 
   case $::osfamily {
diff --git a/spec/classes/ceilometer_init_spec.rb b/spec/classes/ceilometer_init_spec.rb
index 4968266..6cdf6e4 100644
--- a/spec/classes/ceilometer_init_spec.rb
+++ b/spec/classes/ceilometer_init_spec.rb
@@ -48,10 +48,10 @@ describe 'ceilometer' do
 
     it 'configures ceilometer configuration file' do
       should contain_file('/etc/ceilometer/ceilometer.conf').with(
-        :ensure  => 'file',
         :owner   => 'ceilometer',
         :group   => 'ceilometer',
-        :mode    => '0640'
+        :mode    => '0640',
+        :require => 'Package[ceilometer-common]'
       )
     end