From: David Swan <david.swan@puppet.co.uk>
Date: Tue, 12 May 2020 14:39:47 +0000 (+0100)
Subject: (maint) - Pdk Update
X-Git-Tag: v2.5.0~8^2~2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=376020bd1029a2fc6a4622538b8efa9a6882ed3a;p=puppet-modules%2Fpuppetlabs-firewall.git

(maint) - Pdk Update
---

diff --git a/.rubocop.yml b/.rubocop.yml
index bab25db..5307849 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -40,6 +40,10 @@ Style/BlockDelimiters:
   Description: Prefer braces for chaining. Mostly an aesthetical choice. Better to
     be consistent then.
   EnforcedStyle: braces_for_chaining
+Style/BracesAroundHashParameters:
+  Description: Braces are required by Ruby 2.7. Cop removed from RuboCop v0.80.0.
+    See https://github.com/rubocop-hq/rubocop/pull/7643
+  Enabled: true
 Style/ClassAndModuleChildren:
   Description: Compact style reduces the required amount of indentation.
   EnforcedStyle: compact
diff --git a/.travis.yml b/.travis.yml
index 764ec5a..c03acf4 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -32,7 +32,6 @@ jobs:
       - "bundle exec rake 'litmus:provision_list[travis_deb]'"
       - "bundle exec rake 'litmus:install_agent[puppet5]'"
       - "bundle exec rake litmus:install_module"
-      dist: trusty
       bundler_args:
       env: PLATFORMS=travis_deb_puppet5
       rvm: 2.5.7
@@ -44,7 +43,6 @@ jobs:
       - "bundle exec rake 'litmus:provision_list[travis_ub]'"
       - "bundle exec rake 'litmus:install_agent[puppet5]'"
       - "bundle exec rake litmus:install_module"
-      dist: trusty
       bundler_args:
       env: PLATFORMS=travis_ub_puppet5
       rvm: 2.5.7
@@ -56,7 +54,6 @@ jobs:
       - "bundle exec rake 'litmus:provision_list[travis_el7]'"
       - "bundle exec rake 'litmus:install_agent[puppet5]'"
       - "bundle exec rake litmus:install_module"
-      dist: trusty
       bundler_args:
       env: PLATFORMS=travis_el7_puppet5
       rvm: 2.5.7
@@ -68,7 +65,6 @@ jobs:
       - "bundle exec rake 'litmus:provision_list[travis_deb]'"
       - "bundle exec rake 'litmus:install_agent[puppet6]'"
       - "bundle exec rake litmus:install_module"
-      dist: trusty
       bundler_args:
       env: PLATFORMS=travis_deb_puppet6
       rvm: 2.5.7
@@ -80,7 +76,6 @@ jobs:
       - "bundle exec rake 'litmus:provision_list[travis_ub]'"
       - "bundle exec rake 'litmus:install_agent[puppet6]'"
       - "bundle exec rake litmus:install_module"
-      dist: trusty
       bundler_args:
       env: PLATFORMS=travis_ub_puppet6
       rvm: 2.5.7
@@ -92,7 +87,6 @@ jobs:
       - "bundle exec rake 'litmus:provision_list[travis_el7]'"
       - "bundle exec rake 'litmus:install_agent[puppet6]'"
       - "bundle exec rake litmus:install_module"
-      dist: trusty
       bundler_args:
       env: PLATFORMS=travis_el7_puppet6
       rvm: 2.5.7
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
index 6177782..2f1e4f7 100644
--- a/.vscode/extensions.json
+++ b/.vscode/extensions.json
@@ -1,6 +1,6 @@
 {
   "recommendations": [
-    "jpogran.puppet-vscode",
+    "puppet.puppet-vscode",
     "rebornix.Ruby"
   ]
 }
diff --git a/Gemfile b/Gemfile
index adbbe6d..4f6e33b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -29,8 +29,6 @@ group :development do
   gem "puppet-module-win-default-r#{minor_version}", '~> 0.4',   require: false, platforms: [:mswin, :mingw, :x64_mingw]
   gem "puppet-module-win-dev-r#{minor_version}", '~> 0.4',       require: false, platforms: [:mswin, :mingw, :x64_mingw]
   gem "github_changelog_generator",                              require: false, git: 'https://github.com/skywinder/github-changelog-generator', ref: '20ee04ba1234e9e83eb2ffb5056e23d641c7a018' if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.2.2')
-  gem 'ed25519', '>= 1.2', '< 2.0'
-  gem 'bcrypt_pbkdf', '>= 1.0', '< 2.0'
 end
 
 puppet_version = ENV['PUPPET_GEM_VERSION']
diff --git a/metadata.json b/metadata.json
index ad78d24..0b8b830 100644
--- a/metadata.json
+++ b/metadata.json
@@ -78,6 +78,6 @@
     }
   ],
   "template-url": "https://github.com/puppetlabs/pdk-templates#master",
-  "template-ref": "1.17.0-0-gd3a4319",
+  "template-ref": "heads/master-0-g095317c",
   "pdk-version": "1.17.0"
 }
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index bc023f5..16764b6 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -42,6 +42,7 @@ RSpec.configure do |c|
     # set to strictest setting for testing
     # by default Puppet runs at warning level
     Puppet.settings[:strict] = :warning
+    Puppet.settings[:strict_variables] = true
   end
   c.filter_run_excluding(bolt: true) unless ENV['GEM_BOLT']
   c.after(:suite) do