From: Takashi Kajinami <tkajinam@redhat.com>
Date: Mon, 8 Nov 2021 14:24:23 +0000 (+0900)
Subject: Remove unused, outdated unit test cases
X-Git-Tag: 20.0.0~5
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=31b5d7f00be5510576449328659b499f1f655276;p=puppet-modules%2Fpuppet-ceilometer.git

Remove unused, outdated unit test cases

These test cases were added when the metering_secret parameter was
deprecated in favor of the new telemetry_secret parameter[1], but were
not enabled properly.

The deprecated metering_secret parameter was later removed[2] but
these ineffective test cases were not removed at that time.

[1] 4600d4135ac1bef01f7a7dd4b12582a0c8db6b50
[2] f28830d5aae8021215026bdf2f63a8713b7deeb1

Change-Id: I80290f4388e9bb3eb5542a9d1e70ccea81698905
---

diff --git a/spec/classes/ceilometer_init_spec.rb b/spec/classes/ceilometer_init_spec.rb
index 1b08343..a0eccd3 100644
--- a/spec/classes/ceilometer_init_spec.rb
+++ b/spec/classes/ceilometer_init_spec.rb
@@ -250,25 +250,6 @@ describe 'ceilometer' do
     end
   end
 
-
-  # Cleanup in Ocata
-  shared_examples_for 'using old metering_secret param' do
-    context "with old metering_secret param it uses telemetry_secret instead" do
-      before { params.merge!(
-          :metering_secret => 'broncos',
-          :telemetry_secret => 'metering-s3cr3t',
-      ) }
-      it { is_expected.to contain_ceilometer_config('publisher/telemetry_secret').with_value('metering-s3cr3t') }
-    end
-    context "with old metering_secret param set and telemetry_secret unset" do
-      before { params.merge!(
-          :metering_secret => 'broncos',
-          :telemetry_secret => nil,
-      ) }
-      it { is_expected.to contain_ceilometer_config('publisher/telemetry_secret').with_value('broncos') }
-    end
-  end
-
   shared_examples_for 'rabbit with SSL support' do
     context "with default parameters" do
     it { is_expected.to contain_oslo__messaging__rabbit('ceilometer_config').with(