From: Gary Kotton <gkotton@redhat.com>
Date: Sun, 9 Dec 2012 06:33:13 +0000 (+0000)
Subject: Prevent unnecessary database read by l3 agent
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=2e043a5a785b452f8f7fcb104b12c0746ca4a513;p=openstack-build%2Fneutron-build.git

Prevent unnecessary database read by l3 agent

Fixes bug 1088129

Change-Id: I887facf321f3267c16c101a1448827f6c046bb2c
---

diff --git a/quantum/db/l3_db.py b/quantum/db/l3_db.py
index 10a51a4c2..04a7a8f22 100644
--- a/quantum/db/l3_db.py
+++ b/quantum/db/l3_db.py
@@ -864,6 +864,8 @@ class L3_NAT_db_mixin(l3.RouterPluginBase):
             my_ports = subnet_id_ports_dict.get(fixed_ip['subnet_id'], [])
             my_ports.append(port)
             subnet_id_ports_dict[fixed_ip['subnet_id']] = my_ports
+        if not subnet_id_ports_dict:
+            return
         filters = {'id': subnet_id_ports_dict.keys()}
         fields = ['id', 'cidr', 'gateway_ip']
         subnet_dicts = self.get_subnets(context, filters, fields)