From: Paul McMillan <paul.mcmillan@nebula.com>
Date: Tue, 20 Aug 2013 00:58:02 +0000 (+0100)
Subject: Make the SolidFire driver api port configurable.
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=299d06fc06fb63080ac5aa55353d06601f8ad7e4;p=openstack-build%2Fcinder-build.git

Make the SolidFire driver api port configurable.

Making the SolidFire driver api port configurable allows it to be
placed behind a transparent proxy.

Change-Id: I976ecfd5df11797722776faf65777ca1ffa5b0c4
---

diff --git a/cinder/volume/drivers/solidfire.py b/cinder/volume/drivers/solidfire.py
index b9e4e6f60..3dc055577 100644
--- a/cinder/volume/drivers/solidfire.py
+++ b/cinder/volume/drivers/solidfire.py
@@ -47,7 +47,12 @@ sf_opts = [
 
     cfg.StrOpt('sf_account_prefix',
                default=socket.gethostname(),
-               help='Create SolidFire accounts with this prefix'), ]
+               help='Create SolidFire accounts with this prefix'),
+
+    cfg.IntOpt('sf_api_port',
+               default=443,
+               help='SolidFire API port. Useful if the device api is behind '
+                    'a proxy on a different port.'), ]
 
 
 CONF = cfg.CONF
@@ -105,8 +110,7 @@ class SolidFireDriver(SanISCSIDriver):
                                    'xMaxSnapshotsPerNodeExceeded',
                                    'xMaxClonesPerNodeExceeded']
         host = self.configuration.san_ip
-        # For now 443 is the only port our server accepts requests on
-        port = 443
+        port = self.configuration.sf_api_port
 
         cluster_admin = self.configuration.san_login
         cluster_password = self.configuration.san_password
diff --git a/etc/cinder/cinder.conf.sample b/etc/cinder/cinder.conf.sample
index 34d629786..be17a234f 100644
--- a/etc/cinder/cinder.conf.sample
+++ b/etc/cinder/cinder.conf.sample
@@ -1266,12 +1266,19 @@
 # Options defined in cinder.volume.drivers.solidfire
 #
 
-# Set 512 byte emulation on volume creation;  (boolean value)
+# Set 512 byte emulation on volume creation (boolean value)
 #sf_emulate_512=true
 
 # Allow tenants to specify QOS on create (boolean value)
 #sf_allow_tenant_qos=false
 
+# Create solidfire accounts with this prefix. Defaults to current
+# hostname (string value)
+#sf_account_prefix=
+
+# Solidfire API port. Useful if the device is behind a proxy (integer value)
+#sf_api_port=443
+
 
 #
 # Options defined in cinder.volume.drivers.storwize_svc