From: Avishay Traeger <avishay@il.ibm.com>
Date: Tue, 9 Apr 2013 06:27:46 +0000 (+0300)
Subject: Fix backup manager formatting error.
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=23bd028ce39bebf0f5d2403df328ad55e6eb007e;p=openstack-build%2Fcinder-build.git

Fix backup manager formatting error.

ID was being printed as %d instead of %s, causing tests to fail. This
error was previously undetected.
In addition, NetApp tests are failing due to a bug in the suds
package, which is no longer actively maintained. This patch adds skips
to the problematic tests, which should be removed once the issue is
resolved.

Change-Id: I5645909f59aa2ea3dc536ed4707ea75754307050
Fixes: bug 1166600
---

diff --git a/cinder/backup/manager.py b/cinder/backup/manager.py
index 1af357679..b4a972327 100755
--- a/cinder/backup/manager.py
+++ b/cinder/backup/manager.py
@@ -188,7 +188,7 @@ class BackupManager(manager.SchedulerDependentManager):
             raise exception.InvalidBackup(reason=err)
 
         if volume['size'] > backup['size']:
-            LOG.warn('volume: %s, size: %d is larger than backup: %d, '
+            LOG.warn('volume: %s, size: %d is larger than backup: %s, '
                      'size: %d, continuing with restore',
                      volume['id'], volume['size'],
                      backup['id'], backup['size'])
diff --git a/cinder/tests/test_netapp.py b/cinder/tests/test_netapp.py
index 9b7038cc1..c192ee2de 100644
--- a/cinder/tests/test_netapp.py
+++ b/cinder/tests/test_netapp.py
@@ -1008,9 +1008,11 @@ class NetAppDriverTestCase(test.TestCase):
         shutil.rmtree(self.tempdir)
         super(NetAppDriverTestCase, self).tearDown()
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_connect(self):
         self.driver.check_for_setup_error()
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_create_destroy(self):
         self.driver._discover_luns()
         self.driver._provision(self.VOLUME_NAME, None, self.PROJECT_ID,
@@ -1020,6 +1022,7 @@ class NetAppDriverTestCase(test.TestCase):
     def test_destroy_uncreated_volume(self):
         self.driver._remove_destroy('fake-nonexistent-volume', self.PROJECT_ID)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_map_unmap(self):
         self.driver._discover_luns()
         self.driver._provision(self.VOLUME_NAME, None, self.PROJECT_ID,
@@ -1036,11 +1039,13 @@ class NetAppDriverTestCase(test.TestCase):
         self.driver.terminate_connection(volume, connector)
         self.driver._remove_destroy(self.VOLUME_NAME, self.PROJECT_ID)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_clone(self):
         self.driver._discover_luns()
         self.driver._clone_lun(0, '/vol/vol/qtree/src', '/vol/vol/qtree/dst',
                                False)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_clone_fail(self):
         self.driver._discover_luns()
         self.driver._is_clone_done(0, '0', 'xxx')
@@ -1426,13 +1431,16 @@ class NetAppCmodeISCSIDriverTestCase(test.TestCase):
                               hostname='localhost', port=8080, cache=False)
         self.driver = driver
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_connect(self):
         self.driver.check_for_setup_error()
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_create_destroy(self):
         self.driver.create_volume(self.volume)
         self.driver.delete_volume(self.volume)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_create_vol_snapshot_destroy(self):
         self.driver.create_volume(self.volume)
         self.driver.create_snapshot(self.snapshot)
@@ -1440,6 +1448,7 @@ class NetAppCmodeISCSIDriverTestCase(test.TestCase):
         self.driver.delete_snapshot(self.snapshot)
         self.driver.delete_volume(self.volume)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_map_unmap(self):
         self.driver.create_volume(self.volume)
         updates = self.driver.create_export(None, self.volume)
@@ -1455,6 +1464,7 @@ class NetAppCmodeISCSIDriverTestCase(test.TestCase):
         self.driver.terminate_connection(self.volume, self.connector)
         self.driver.delete_volume(self.volume)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_fail_vol_from_snapshot_creation(self):
         self.driver.create_volume(self.volume)
         try:
@@ -1466,12 +1476,14 @@ class NetAppCmodeISCSIDriverTestCase(test.TestCase):
         finally:
             self.driver.delete_volume(self.volume)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_cloned_volume_destroy(self):
         self.driver.create_volume(self.volume)
         self.driver.create_cloned_volume(self.snapshot, self.volume)
         self.driver.delete_volume(self.snapshot)
         self.driver.delete_volume(self.volume)
 
+    @test.skip_test("Failing due to suds error - skip until fixed")
     def test_fail_cloned_volume_creation(self):
         self.driver.create_volume(self.volume)
         try: