From: Assaf Muller <amuller@redhat.com>
Date: Tue, 7 Oct 2014 19:45:41 +0000 (+0300)
Subject: Forbid update of HA property of routers
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=234c9e6d66c867e87f6e0eb8b0fa84240f6f8c4a;p=openstack-build%2Fneutron-build.git

Forbid update of HA property of routers

While the HA property is update-able, and resulting router-get
invocations suggest that the router is HA, the migration
itself fails on the agent. This is deceiving and confusing
and should be blocked until the migration itself is fixed
in a future patch.

Change-Id: I4171ab481e3943e0110bd9a300d965bbebe44871
Related-Bug: #1365426
Closes-Bug: #1378525
(cherry picked from commit 1fd7dd99ca7e5e9736200360aa354cada7fb43ff)
---

diff --git a/neutron/extensions/l3_ext_ha_mode.py b/neutron/extensions/l3_ext_ha_mode.py
index f8487bb5b..115a8db81 100644
--- a/neutron/extensions/l3_ext_ha_mode.py
+++ b/neutron/extensions/l3_ext_ha_mode.py
@@ -21,7 +21,7 @@ from neutron.common import exceptions
 HA_INFO = 'ha'
 EXTENDED_ATTRIBUTES_2_0 = {
     'routers': {
-        HA_INFO: {'allow_post': True, 'allow_put': True,
+        HA_INFO: {'allow_post': True, 'allow_put': False,
                   'default': attributes.ATTR_NOT_SPECIFIED, 'is_visible': True,
                   'enforce_policy': True,
                   'convert_to': attributes.convert_to_boolean_if_not_none}